13 "github.com/stretchr/testify/require"
16 func TestOwnerTalksToTheAgentThroughTelegram(t *testing.T) {
17 server := newModelFake(t)
18 server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
19 modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem("Hello from the agent.")}, 100, 0, 5))
22 telegram := newTelegramFake(t)
23 bot, _ := telegramStartTestBot(t, telegram)
24 socket := daemonStartTestWithBot(t, server, bot)
25 terminal := terminalStartTestClient(t, socket)
26 terminal.WaitFor(t, "[connected to OneChat]")
28 telegram.Add(TelegramUpdate{
30 Message: telegramOwnerMessage("hi from the phone"),
33 terminal.WaitFor(t, "[telegram] hi from the phone\n[working]\nHello from the agent.\n[done]")
34 telegramWaitForSent(t, telegram, "Hello from the agent.")
35 require.True(t, slices.ContainsFunc(telegram.Calls(), func(call TelegramFakeCall) bool {
36 return call.method == "sendChatAction" && call.params["action"] == "typing"
39 terminal.Type("hi from the desk")
40 require.Equal(t, []string{"Hello from the agent.", "[terminal] hi from the desk", "Hello from the agent."}, telegramWaitForSent(t, telegram, "Hello from the agent.", "[terminal] hi from the desk", "Hello from the agent."))
43 func TestBotIgnoresEveryoneButTheOwner(t *testing.T) {
44 telegram := newTelegramFake(t)
45 bot, logs := telegramStartTestBot(t, telegram)
46 socket := daemonStartTestWithBot(t, newModelFake(t), bot)
47 terminal := terminalStartTestClient(t, socket)
48 terminal.WaitFor(t, "[connected to OneChat]")
50 group := telegramOwnerMessage("secret in a group")
51 group.Chat = TelegramChat{
56 stranger := telegramOwnerMessage("secret of a stranger")
60 unsigned := telegramOwnerMessage("secret with no sender")
63 for id, message := range []*TelegramMessage{group, stranger, unsigned, nil} {
64 telegram.Add(TelegramUpdate{
65 UpdateID: int64(10 + id),
70 require.Eventually(t, func() bool {
71 offset, err := telegramLoadOffset(bot.offsetPath)
72 return err == nil && offset == 14
73 }, 10*time.Second, time.Millisecond)
75 require.Empty(t, telegram.Sent())
76 require.NotContains(t, terminal.Output(), "secret")
77 require.NotContains(t, logs.String(), "secret")
78 require.Contains(t, logs.String(), "update ignored")
81 func TestBotAnswersThatOnlyTextIsSupported(t *testing.T) {
82 telegram := newTelegramFake(t)
83 bot, _ := telegramStartTestBot(t, telegram)
84 daemonStartTestWithBot(t, newModelFake(t), bot)
86 telegram.Add(TelegramUpdate{
88 Message: telegramOwnerMessage(""),
91 telegramWaitForSent(t, telegram, telegramTextOnly)
94 func TestStopFromTelegramInterruptsTheTurn(t *testing.T) {
95 server := newModelFake(t)
96 arrived := make(chan struct{})
97 release := make(chan struct{})
102 server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
107 telegram := newTelegramFake(t)
108 bot, _ := telegramStartTestBot(t, telegram)
109 daemonStartTestWithBot(t, server, bot)
111 telegram.Add(TelegramUpdate{
113 Message: telegramOwnerMessage("a long task"),
117 telegram.Add(TelegramUpdate{
119 Message: telegramOwnerMessage(stopCommand),
122 telegramWaitForSent(t, telegram, "Error: interrupted")
124 telegram.Add(TelegramUpdate{
126 Message: telegramOwnerMessage(stopCommand),
129 telegramWaitForSent(t, telegram, "Error: interrupted", "No turn runs.")
132 func TestBotStartsAtTheStoredOffset(t *testing.T) {
133 server := newModelFake(t)
134 server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
135 modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem("ok")}, 100, 0, 5))
138 telegram := newTelegramFake(t)
139 bot, _ := telegramStartTestBot(t, telegram)
140 require.NoError(t, telegramSaveOffset(bot.offsetPath, 10))
142 telegram.Add(TelegramUpdate{
144 Message: telegramOwnerMessage("handled before the restart"),
147 telegram.Add(TelegramUpdate{
149 Message: telegramOwnerMessage("new after the restart"),
152 socket := daemonStartTestWithBot(t, server, bot)
153 terminal := terminalStartTestClient(t, socket)
154 terminal.WaitFor(t, "[connected to OneChat]")
155 telegramWaitForSent(t, telegram, "ok")
157 require.Equal(t, float64(10), telegram.Calls()[0].params["offset"])
158 require.NotContains(t, terminal.Output(), "handled before the restart")
160 require.Eventually(t, func() bool {
161 offset, err := telegramLoadOffset(bot.offsetPath)
162 return err == nil && offset == 11
163 }, 10*time.Second, time.Millisecond)
166 func TestBotTriesAgainAfterFailures(t *testing.T) {
167 server := newModelFake(t)
168 server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
169 modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem("ok")}, 100, 0, 5))
172 telegram := newTelegramFake(t)
173 failures := map[string]int{
175 "sendRichMessage": 1,
178 telegram.fail = func(call TelegramFakeCall) (int, string) {
179 if failures[call.method] == 0 {
183 failures[call.method]--
184 if call.method == "sendRichMessage" {
185 return http.StatusTooManyRequests, "Too Many Requests: retry after 1"
188 return http.StatusBadGateway, "Bad Gateway"
191 bot, logs := telegramStartTestBot(t, telegram)
192 daemonStartTestWithBot(t, server, bot)
194 telegram.Add(TelegramUpdate{
196 Message: telegramOwnerMessage("hello"),
199 telegramWaitForSent(t, telegram, "ok")
200 require.Contains(t, logs.String(), "answered 502")
201 require.Contains(t, logs.String(), "answered 429")
202 require.NotContains(t, logs.String(), telegramTestToken)
205 func TestDeliverTriesAgainAfterATimeout(t *testing.T) {
206 telegram := newTelegramFake(t)
208 telegram.stall = func(call TelegramFakeCall) bool {
209 if call.method != "sendMessage" || stalls == 0 {
218 bot, logs := telegramStartTestBot(t, telegram)
219 bot.api.sendTimeout = 50 * time.Millisecond
220 bot.deliver(t.Context(), TelegramPart{
224 require.Equal(t, []string{"hello"}, telegram.Sent())
225 require.Len(t, telegram.Calls(), 2)
226 require.Contains(t, logs.String(), "no valid answer")
227 require.NotContains(t, logs.String(), telegramTestToken)
230 func TestRepliesGoAsRichMessages(t *testing.T) {
231 reply := "**Done.** The table:\n\n| Name | Size |\n|:-----|-----:|\n| `a.go` | 10 |\n\n- one\n- two\n\n```go\nx := 1\n```"
232 server := newModelFake(t)
233 server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
234 modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem(reply)}, 100, 0, 5))
237 telegram := newTelegramFake(t)
238 bot, _ := telegramStartTestBot(t, telegram)
239 socket := daemonStartTestWithBot(t, server, bot)
240 terminal := terminalStartTestClient(t, socket)
241 terminal.WaitFor(t, "[connected to OneChat]")
243 terminal.Type("make **it** so")
244 telegramWaitForSent(t, telegram, "[terminal] make **it** so", reply)
246 telegram.Add(TelegramUpdate{
248 Message: telegramOwnerMessage(""),
251 telegramWaitForSent(t, telegram, telegramTextOnly)
253 var sends []TelegramFakeCall
254 for _, call := range telegram.Calls() {
255 if call.method == "sendMessage" || call.method == "sendRichMessage" {
256 sends = append(sends, call)
260 require.Equal(t, []TelegramFakeCall{
262 method: "sendMessage",
263 params: map[string]any{
264 "chat_id": float64(telegramTestOwner),
265 "text": "[terminal] make **it** so",
270 method: "sendRichMessage",
271 params: map[string]any{
272 "chat_id": float64(telegramTestOwner),
273 "rich_message": map[string]any{
280 method: "sendMessage",
281 params: map[string]any{
282 "chat_id": float64(telegramTestOwner),
283 "text": telegramTextOnly,
290 func TestRichMessageFailures(t *testing.T) {
291 testCases := []struct {
300 name: "bad request sends the reply once with entities",
301 status: http.StatusBadRequest,
303 methods: []string{"sendRichMessage", "sendMessage"},
304 sent: []string{"a secret word"},
305 logText: "rich message refused",
308 name: "unknown method sends the reply once with entities",
309 status: http.StatusNotFound,
311 methods: []string{"sendRichMessage", "sendMessage"},
312 sent: []string{"a secret word"},
313 logText: "rich message refused",
316 name: "rate limit tries the rich message again",
317 status: http.StatusTooManyRequests,
318 methods: []string{"sendRichMessage", "sendRichMessage"},
319 sent: []string{"a **secret** word"},
320 logText: "answered 429",
323 name: "server error tries the rich message again",
324 status: http.StatusInternalServerError,
325 methods: []string{"sendRichMessage", "sendRichMessage"},
326 sent: []string{"a **secret** word"},
327 logText: "answered 500",
330 name: "other refusal drops the reply",
331 status: http.StatusForbidden,
333 methods: []string{"sendRichMessage"},
334 logText: "message dropped",
338 for _, tc := range testCases {
339 t.Run(tc.name, func(t *testing.T) {
340 telegram := newTelegramFake(t)
342 telegram.fail = func(call TelegramFakeCall) (int, string) {
343 if call.method != "sendRichMessage" || failed && !tc.always {
349 return tc.status, "refused for bot" + telegramTestToken
352 bot, logs := telegramStartTestBot(t, telegram)
353 bot.post(t.Context(), Event{
355 Text: "a **secret** word",
359 for _, call := range telegram.Calls() {
360 methods = append(methods, call.method)
363 require.Equal(t, tc.methods, methods)
364 require.Equal(t, tc.sent, telegram.Sent())
365 require.Equal(t, 1, strings.Count(logs.String(), "\n"))
366 require.Contains(t, logs.String(), tc.logText)
367 require.NotContains(t, logs.String(), telegramTestToken)
368 require.NotContains(t, logs.String(), "secret word")
370 calls := telegram.Calls()
371 if calls[len(calls)-1].method == "sendMessage" {
372 require.NotNil(t, calls[len(calls)-1].params["entities"])
378 func TestLongReplyGoesAsRichMessagesSplitBetweenBlocks(t *testing.T) {
379 paragraphs := strings.Repeat("A paragraph of the reply.\n\n", telegramRichBytes/len("A paragraph of the reply.\n\n"))
380 table := "| a | b |\n|---|---|\n| 1 | 2 |\n"
381 reply := paragraphs + table
383 telegram := newTelegramFake(t)
384 bot, _ := telegramStartTestBot(t, telegram)
385 bot.post(t.Context(), Event{
390 require.Equal(t, []string{paragraphs, table}, telegram.Sent())
393 func TestReplyTagsGoAsText(t *testing.T) {
394 testCases := []struct {
400 name: "rich message escapes the tag outside code",
401 sent: []string{"a \\<details> tag and `<b>`"},
404 name: "entity fallback shows the tag as written",
405 status: http.StatusBadRequest,
406 sent: []string{"a <details> tag and <b>"},
410 for _, tc := range testCases {
411 t.Run(tc.name, func(t *testing.T) {
412 telegram := newTelegramFake(t)
413 telegram.fail = func(call TelegramFakeCall) (int, string) {
414 if call.method != "sendRichMessage" {
418 return tc.status, "Bad Request"
421 bot, _ := telegramStartTestBot(t, telegram)
422 bot.post(t.Context(), Event{
424 Text: "a <details> tag and `<b>`",
427 require.Equal(t, tc.sent, telegram.Sent())
432 func TestLongReplySplitCountsTheEscapedTags(t *testing.T) {
433 paragraph := "A <b> tag.\n\n"
434 count := telegramRichBytes / len(paragraph)
435 reply := strings.Repeat(paragraph, count)
436 require.LessOrEqual(t, len(reply), telegramRichBytes)
438 telegram := newTelegramFake(t)
439 bot, _ := telegramStartTestBot(t, telegram)
440 bot.post(t.Context(), Event{
445 sent := telegram.Sent()
446 require.Len(t, sent, 2)
447 require.Equal(t, telegramEscapeTags(reply), strings.Join(sent, ""))
449 for _, markdown := range sent {
450 require.LessOrEqual(t, len(markdown), telegramRichBytes)
454 func TestRefusedEntitiesGoAgainAsPlainText(t *testing.T) {
455 telegram := newTelegramFake(t)
456 telegram.fail = func(call TelegramFakeCall) (int, string) {
457 if call.params["entities"] == nil {
461 return http.StatusBadRequest, "Bad Request: can't parse entities of bot" + telegramTestToken
464 bot, logs := telegramStartTestBot(t, telegram)
465 text, entities := telegramMarkdownEntities("a **secret** word")
466 bot.deliver(t.Context(), TelegramPart{
471 calls := telegram.Calls()
472 require.Len(t, calls, 2)
473 require.NotNil(t, calls[0].params["entities"])
474 require.Nil(t, calls[1].params["entities"])
475 require.Equal(t, []string{"a secret word"}, telegram.Sent())
476 require.Equal(t, 1, strings.Count(logs.String(), "\n"))
477 require.Contains(t, logs.String(), "entities refused")
478 require.NotContains(t, logs.String(), telegramTestToken)
479 require.NotContains(t, logs.String(), "secret word")
482 func TestBotLogsNoTokenWhenTheNetworkFails(t *testing.T) {
483 telegram := newTelegramFake(t)
486 bot, logs := telegramStartTestBot(t, telegram)
487 daemonStartTestWithBot(t, newModelFake(t), bot)
489 require.Eventually(t, func() bool {
490 return strings.Count(logs.String(), "no valid answer") >= 2
491 }, 10*time.Second, time.Millisecond)
492 require.NotContains(t, logs.String(), telegramTestToken)
495 func TestSplitMessage(t *testing.T) {
496 testCases := []struct {
503 name: "short text stays whole",
506 parts: []string{"one two"},
509 name: "cut after the last line break",
510 text: "first line\nsecond line",
512 parts: []string{"first line\n", "second line"},
515 name: "cut after the last space without a line break",
516 text: "aaaa bbbb cccc",
518 parts: []string{"aaaa bbbb ", "cccc"},
521 name: "hard cut of one long word",
524 parts: []string{"abcd", "efgh", "ij"},
527 name: "a character outside the BMP counts two units and is not cut",
528 text: "ab\U0001F600cd",
530 parts: []string{"ab", "\U0001F600c", "d"},
534 for _, tc := range testCases {
535 t.Run(tc.name, func(t *testing.T) {
536 require.Equal(t, tc.parts, telegramSplitMessage(tc.text, tc.limit))
540 long := strings.Repeat("word ", 2000)
541 parts := telegramSplitMessage(long, telegramMessageUnits)
542 require.Len(t, parts, 3)
543 require.Equal(t, long, strings.Join(parts, ""))
546 func TestSplitEntitiesCutsAnEntityAcrossASplit(t *testing.T) {
547 parts := telegramSplitEntities("aabbbbcc", []TelegramEntity{
560 require.Equal(t, []TelegramPart{
563 entities: []TelegramEntity{
573 entities: []TelegramEntity{
589 func TestSplitRich(t *testing.T) {
590 testCases := []struct {
597 name: "short reply stays whole",
598 markdown: "| a | b |",
600 parts: []string{"| a | b |"},
603 name: "cut after a blank line keeps a table whole",
604 markdown: "Intro.\n\n| a | b |\n|---|---|\n| 1 | 2 |\n",
606 parts: []string{"Intro.\n\n", "| a | b |\n|---|---|\n| 1 | 2 |\n"},
609 name: "blank line in a code block is not a cut",
610 markdown: "Text.\n\n```go\nx\n\ny\n```\n\nEnd.\n",
612 parts: []string{"Text.\n\n", "```go\nx\n\ny\n```\n\n", "End.\n"},
615 name: "paragraph with no blank line is cut after a line",
616 markdown: "aaa\nbbb\nccc\n",
618 parts: []string{"aaa\nbbb\n", "ccc\n"},
621 name: "long code block is closed and opened again",
622 markdown: "```sh\none\ntwo\nthree\n```\n",
624 parts: []string{"```sh\none\n```\n", "```sh\ntwo\n```\n", "```sh\nthree\n```\n"},
627 name: "long line is cut at the limit and not inside a character",
628 markdown: "ab\u00e9cd",
630 parts: []string{"ab", "\u00e9c", "d"},
634 for _, tc := range testCases {
635 t.Run(tc.name, func(t *testing.T) {
636 require.Equal(t, tc.parts, telegramSplitRich(tc.markdown, tc.limit))
640 long := strings.Repeat("A paragraph of the reply.\n\n", 2000)
641 parts := telegramSplitRich(long, telegramRichBytes)
642 require.Len(t, parts, 2)
643 require.Len(t, parts[0], telegramRichBytes-telegramRichBytes%len("A paragraph of the reply.\n\n"))
644 require.Equal(t, long, strings.Join(parts, ""))
647 func TestLoadBotConfig(t *testing.T) {
648 testCases := []struct {
655 name: "owner file is read",
656 content: `{"token": "` + telegramTestToken + `", "owner": 4242}`,
660 name: "file that others can read is refused",
661 content: `{"token": "` + telegramTestToken + `", "owner": 4242}`,
663 errorText: "mode must be 0600",
666 name: "token with a path character is refused",
667 content: `{"token": "123:abc/../x", "owner": 4242}`,
669 errorText: "form of a bot token",
672 name: "missing owner is refused",
673 content: `{"token": "` + telegramTestToken + `"}`,
675 errorText: "numeric Telegram user ID",
678 name: "unknown field is refused",
679 content: `{"token": "` + telegramTestToken + `", "owner": 4242, "chat": 1}`,
681 errorText: "not valid JSON",
685 for _, tc := range testCases {
686 t.Run(tc.name, func(t *testing.T) {
688 path := filepath.Join(dir, telegramConfigFileName)
689 require.NoError(t, os.WriteFile(path, []byte(tc.content), tc.mode))
690 require.NoError(t, os.Chmod(path, tc.mode))
692 config, found, err := loadTelegramConfig(dir)
693 if tc.errorText != "" {
694 require.ErrorContains(t, err, tc.errorText)
695 require.NotContains(t, err.Error(), telegramTestToken)
700 require.NoError(t, err)
701 require.True(t, found)
702 require.Equal(t, TelegramConfig{
703 Token: telegramTestToken,
704 Owner: telegramTestOwner,
709 _, found, err := loadTelegramConfig(t.TempDir())
710 require.NoError(t, err)
711 require.False(t, found)
714 // telegramStartTestBot returns a bot of telegramTestOwner on server, with its
715 // offset file in a temporary directory and short waits, and the buffer of its
717 func telegramStartTestBot(t *testing.T, server *TelegramFake) (*TelegramBot, *SyncBuffer) {
720 logs := &SyncBuffer{}
721 bot := newTelegramBot(newTelegramAPI(server.URL, telegramTestToken), telegramTestOwner, filepath.Join(t.TempDir(), telegramOffsetFileName), log.New(logs, "", 0))
722 bot.minWait = time.Millisecond
723 bot.maxWait = 10 * time.Millisecond
728 // telegramWaitForSent waits until the bot sent the texts in order, and returns
730 func telegramWaitForSent(t *testing.T, server *TelegramFake, texts ...string) []string {
733 require.Eventually(t, func() bool {
734 sent := server.Sent()
735 return len(sent) >= len(texts) && slices.Equal(sent[len(sent)-len(texts):], texts)
736 }, 10*time.Second, time.Millisecond, "sent so far: %q", server.Sent())