git.giacomolli.uk - onechat/blob - compactor_test.go

   1 package main
   2
   3 import (
   4         "encoding/json"
   5         "io"
   6         "net/http"
   7         "path/filepath"
   8         "strconv"
   9         "strings"
  10         "testing"
  11         "unicode/utf8"
  12
  13         "github.com/stretchr/testify/require"
  14 )
  15
  16 func TestCompactorSendsThePromptToolsAndTask(t *testing.T) {
  17         server := newModelFake(t)
  18         compactor := newTestCompactor(t, server)
  19
  20         line, err := compactor.Summarize(t.Context(), Task{
  21                 Level:   0,
  22                 Index:   7,
  23                 Context: "<chat>\n0+4|user: earlier\n</chat>",
  24                 Input:   []string{"user: " + strings.Repeat("x", 600)},
  25         })
  26         require.NoError(t, err)
  27         require.Equal(t, "a line", line)
  28         require.Equal(t, 1, server.Calls())
  29
  30         body := server.Call(0).body
  31         require.Equal(t, prompt("Ada", "/AGENT/instructions.md", ""), body["instructions"])
  32         require.Equal(t, "gpt-test", body["model"])
  33         require.Equal(t, map[string]any{"effort": "high"}, body["reasoning"])
  34         require.Equal(t, "agent-key", body["prompt_cache_key"])
  35
  36         tools, err := json.Marshal(promptTools())
  37         require.NoError(t, err)
  38
  39         sent, err := json.Marshal(body["tools"])
  40         require.NoError(t, err)
  41         require.JSONEq(t, string(tools), string(sent))
  42
  43         texts := compactorInputTexts(t, server.Call(0))
  44         require.Equal(t, []string{
  45                 "<chat>\n0+4|user: earlier\n</chat>\n" +
  46                         "Compaction: compress message 7 into one line of at most 512 bytes\n" +
  47                         "(about 70 words), the length of this ruler:\n" +
  48                         strings.Repeat("-", 512) + "\n" +
  49                         "<input>\nuser: " + strings.Repeat("x", 600) + "\n</input>",
  50         }, texts)
  51 }
  52
  53 func TestCompactorSendsEachWholeBlockOfTheViewAsAMessage(t *testing.T) {
  54         testCases := []struct {
  55                 name    string
  56                 context string
  57                 want    []string
  58         }{
  59                 {
  60                         name:    "empty view goes with the task",
  61                         context: "<chat>\n</chat>",
  62                         want:    []string{"<chat>\n</chat>\nTASK"},
  63                 },
  64                 {
  65                         name:    "lines short of a block go with the task",
  66                         context: "<chat>\n0+1|a\n1+1|b\n2+1|c\n</chat>",
  67                         want:    []string{"<chat>\n0+1|a\n1+1|b\n2+1|c\n</chat>\nTASK"},
  68                 },
  69                 {
  70                         name:    "one whole block and the task",
  71                         context: "<chat>\n0+1|a\n1+1|b\n2+1|c\n3+1|d\n</chat>",
  72                         want:    []string{"<chat>\n0+1|a\n1+1|b\n2+1|c\n3+1|d\n", "</chat>\nTASK"},
  73                 },
  74                 {
  75                         name:    "two whole blocks and the rest with the task",
  76                         context: "<chat>\n0+2|a\n2+1|b\n3+1|c\n4+1|d\n5+1|e\n6+1|f\n7+1|g\n8+1|h\n9+1|i\n</chat>",
  77                         want: []string{
  78                                 "<chat>\n0+2|a\n2+1|b\n3+1|c\n4+1|d\n",
  79                                 "5+1|e\n6+1|f\n7+1|g\n8+1|h\n",
  80                                 "9+1|i\n</chat>\nTASK",
  81                         },
  82                 },
  83         }
  84
  85         for _, tc := range testCases {
  86                 t.Run(tc.name, func(t *testing.T) {
  87                         server := newModelFake(t)
  88                         task := compactorLeafTask()
  89                         task.Context = tc.context
  90
  91                         _, err := newTestCompactor(t, server).Summarize(t.Context(), task)
  92                         require.NoError(t, err)
  93
  94                         text, err := compactorTask(task)
  95                         require.NoError(t, err)
  96
  97                         want := make([]string, len(tc.want))
  98                         for n, message := range tc.want {
  99                                 want[n] = strings.Replace(message, "TASK", text, 1)
 100                         }
 101
 102                         texts := compactorInputTexts(t, server.Call(0))
 103                         require.Equal(t, want, texts)
 104                         require.Equal(t, tc.context+"\n"+text, strings.Join(texts, ""))
 105                 })
 106         }
 107 }
 108
 109 func TestCompactorSendsTheSameBlocksForViewsWithTheSameFirstLines(t *testing.T) {
 110         shared := "<chat>\n0+4|a\n4+1|b\n5+1|c\n6+1|d\n7+1|e\n8+1|f\n9+1|g\n10+1|h\n"
 111         server := newModelFake(t)
 112         compactor := newTestCompactor(t, server)
 113         _, err := compactor.Summarize(t.Context(), Task{
 114                 Level:   0,
 115                 Index:   11,
 116                 Context: shared + "11+1|i\n</chat>",
 117                 Input:   []string{"user: eleven"},
 118         })
 119         require.NoError(t, err)
 120
 121         _, err = compactor.Summarize(t.Context(), Task{
 122                 Level:   1,
 123                 Index:   5,
 124                 Context: shared + "11+1|j\n12+1|k\n</chat>",
 125                 Input:   []string{"left line", "right line"},
 126         })
 127         require.NoError(t, err)
 128
 129         first := compactorInputTexts(t, server.Call(0))
 130         second := compactorInputTexts(t, server.Call(1))
 131         require.Len(t, first, 3)
 132         require.Len(t, second, 3)
 133         require.Equal(t, first[:2], second[:2])
 134         require.NotEqual(t, first[2], second[2])
 135 }
 136
 137 func TestCompactorWritesTheMergeTask(t *testing.T) {
 138         text, err := compactorTask(Task{
 139                 Level: 2,
 140                 Index: 3,
 141                 Input: []string{"left line", "right line"},
 142         })
 143         require.NoError(t, err)
 144         require.Equal(t, "Compaction: merge lines 12+2 and 14+2, adjacent, into one line of at most\n"+
 145                 "512 bytes (about 70 words), the length of this ruler:\n"+
 146                 strings.Repeat("-", 512)+"\n"+
 147                 "<chat> may hold their messages, 12 to 15, in more detail: take details\n"+
 148                 "of them from there too.\n"+
 149                 "<input>\nleft line\nright line\n</input>", text)
 150 }
 151
 152 func TestCompactorRetriesALongLineWithTheNewestNote(t *testing.T) {
 153         long := []string{strings.Repeat("a", 600), strings.Repeat("b", 550), strings.Repeat("c", 400)}
 154         server := newModelFake(t)
 155         server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
 156                 modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem(long[call.number])}, 100, 0, 5))
 157         }
 158
 159         task := compactorLeafTask()
 160         task.Context = "<chat>\n0+1|a\n1+1|b\n2+1|c\n3+1|d\n4+1|e\n</chat>"
 161
 162         compactor := newTestCompactor(t, server)
 163         line, err := compactor.Summarize(t.Context(), task)
 164         require.NoError(t, err)
 165         require.Equal(t, long[2], line)
 166         require.Equal(t, 3, server.Calls())
 167
 168         records := modelReadUsage(t, compactor.client.usage.path)
 169         require.Len(t, records, 3)
 170
 171         for n, record := range records {
 172                 require.Equal(t, &[2]int{0, 0}, record.Node)
 173                 require.Equal(t, len(long[n]), record.TextBytes)
 174         }
 175
 176         first := compactorInputTexts(t, server.Call(0))
 177         require.Len(t, first, 2)
 178
 179         for n, want := range []string{long[0], long[1]} {
 180                 call := server.Call(n + 1)
 181                 texts := compactorInputTexts(t, call)
 182                 require.Equal(t, first, texts[:2])
 183                 require.Equal(t, []string{compactorTooLong(want)}, texts[2:])
 184                 require.Contains(t, texts[2], "was "+strconv.Itoa(len(want))+" bytes,")
 185                 require.Contains(t, texts[2], "\n"+want[:512]+"| <- LIMIT")
 186
 187                 note, err := json.Marshal(modelUserMessage(texts[2]))
 188                 require.NoError(t, err)
 189                 require.LessOrEqual(t, len(call.raw), len(server.Call(0).raw)+len(",")+len(note))
 190         }
 191 }
 192
 193 func TestCompactorKeepsTheShortestOfFiveLines(t *testing.T) {
 194         sizes := []int{700, 530, 600, 520, 560, 513}
 195         server := newModelFake(t)
 196         server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
 197                 modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem(strings.Repeat("z", sizes[call.number]))}, 100, 0, 5))
 198         }
 199
 200         line, err := newTestCompactor(t, server).Summarize(t.Context(), compactorLeafTask())
 201         require.NoError(t, err)
 202         require.Equal(t, compactorTries, server.Calls())
 203         require.Len(t, line, 520)
 204 }
 205
 206 func TestCompactorFailsWithoutALine(t *testing.T) {
 207         testCases := []struct {
 208                 name  string
 209                 reply func(http.ResponseWriter, ModelFakeCall)
 210                 want  string
 211         }{
 212                 {
 213                         name: "failed call",
 214                         reply: func(w http.ResponseWriter, _ ModelFakeCall) {
 215                                 w.WriteHeader(http.StatusInternalServerError)
 216
 217                                 _, _ = io.WriteString(w, "down")
 218                         },
 219                         want: "HTTP 500",
 220                 },
 221                 {
 222                         name: "tool call and no text",
 223                         reply: func(w http.ResponseWriter, _ ModelFakeCall) {
 224                                 modelWriteEvents(w, modelCompletedEvent([]any{map[string]any{"type": "function_call", "name": "zoom", "arguments": "{}"}}, 100, 0, 5))
 225                         },
 226                         want: "no line",
 227                 },
 228         }
 229
 230         for _, tc := range testCases {
 231                 t.Run(tc.name, func(t *testing.T) {
 232                         server := newModelFake(t)
 233                         server.reply = tc.reply
 234
 235                         _, err := newTestCompactor(t, server).Summarize(t.Context(), compactorLeafTask())
 236                         require.ErrorContains(t, err, tc.want)
 237                         require.Equal(t, 1, server.Calls())
 238                 })
 239         }
 240 }
 241
 242 func TestCutLineKeepsWholeCharacters(t *testing.T) {
 243         line := strings.Repeat("a", 511) + "é" + "tail"
 244         cut := compactorCutLine(line)
 245         require.Equal(t, strings.Repeat("a", 511), cut)
 246         require.True(t, utf8.ValidString(cut))
 247         require.Equal(t, "short", compactorCutLine("short"))
 248 }
 249
 250 func TestCompactorBuildsNodesInTheCore(t *testing.T) {
 251         server := newModelFake(t)
 252         server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
 253                 if call.number == 0 {
 254                         w.WriteHeader(http.StatusServiceUnavailable)
 255
 256                         return
 257                 }
 258
 259                 modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem("summary of the long output")}, 100, 0, 5))
 260         }
 261
 262         memory, err := openMemory(t.Context(), t.TempDir(), newTestClock().Now, newTestCompactor(t, server), discardLog())
 263         require.NoError(t, err)
 264
 265         defer func() {
 266                 require.NoError(t, memory.Close())
 267         }()
 268
 269         _, err = memory.Append("echo", strings.Repeat("output ", 200))
 270         require.NoError(t, err)
 271         require.NoError(t, memory.Wait(t.Context()))
 272         require.False(t, treeIsBuilt(t, memory.tree, 0, 0))
 273
 274         _, err = memory.Append("user", "next")
 275         require.NoError(t, err)
 276         require.NoError(t, memory.Wait(t.Context()))
 277
 278         node := treeReadNode(t, memory.tree, 0, 0)
 279         require.Equal(t, "summary of the long output", node.Text)
 280         require.Equal(t, "<chat>\n0+1|summary of the long output\n1+1|user: next\n</chat>", memory.View())
 281         require.Equal(t, 2, server.Calls())
 282 }
 283
 284 func newTestCompactor(t *testing.T, server *ModelFake) *Compactor {
 285         t.Helper()
 286
 287         client := newModelClient(server.URL, ModelAPIKey(modelTestKey), "agent-key", filepath.Join(t.TempDir(), "usage.jsonl"))
 288
 289         return newCompactor(client, compactorAdaPrompt, ModelConfig{
 290                 Model:  "gpt-test",
 291                 Effort: "high",
 292         })
 293 }
 294
 295 // compactorInputTexts returns the text of each user message of call. Each
 296 // message has one text part.
 297 func compactorInputTexts(t *testing.T, call ModelFakeCall) []string {
 298         t.Helper()
 299
 300         var body struct {
 301                 Input []struct {
 302                         Role    string `json:"role"`
 303                         Content []struct {
 304                                 Type string `json:"type"`
 305                                 Text string `json:"text"`
 306                         } `json:"content"`
 307                 } `json:"input"`
 308         }
 309
 310         require.NoError(t, json.Unmarshal(call.raw, &body))
 311
 312         texts := make([]string, len(body.Input))
 313         for n, message := range body.Input {
 314                 require.Equal(t, "user", message.Role)
 315                 require.Len(t, message.Content, 1)
 316                 require.Equal(t, "input_text", message.Content[0].Type)
 317
 318                 texts[n] = message.Content[0].Text
 319         }
 320
 321         return texts
 322 }
 323
 324 func compactorLeafTask() Task {
 325         return Task{
 326                 Level:   0,
 327                 Index:   0,
 328                 Context: "<chat>\n</chat>",
 329                 Input:   []string{"user: " + strings.Repeat("y", 600)},
 330         }
 331 }
 332
 333 // compactorAdaPrompt returns the prompt of the agent Ada, without instructions.
 334 func compactorAdaPrompt() (string, error) {
 335         return prompt("Ada", "/AGENT/instructions.md", ""), nil
 336 }