]> git.giacomolli.uk - onechat/commitdiff
Check forced-disconnect test setup failures
authorAnderson A. Giacomolli <redacted>
Wed, 11 Nov 2026 15:04:03 +0000 (12:04 -0300)
committerAnderson A. Giacomolli <redacted>
Wed, 11 Nov 2026 15:04:03 +0000 (12:04 -0300)
The HTTP failure fixture checks whether it can take over the test
connection before closing it. A setup failure cannot silently become a
different network failure. Only the deliberate disconnect close remains
a justified nonfatal discard.

Issue: 3cdc678

telegram_api_test.go

index 0da139590f312a1014863ce98a9411ed6806495e..4395d6b3d0e00f11bff8c9c13718782460f7270e 100644 (file)
@@ -149,11 +149,13 @@ func TestBotErrorsDoNotHoldTheToken(t *testing.T) {
                        name: "refused connection is retried",
                        reply: func(w http.ResponseWriter) {
                                conn, _, err := http.NewResponseController(w).Hijack()
-                               if err == nil {
-                                       // This forced disconnect has no
-                                       // response or retry after close.
-                                       conn.Close() // nolint: errcheck
+                               if err != nil {
+                                       panic(err)
                                }
+
+                               // This forced disconnect has no response or
+                               // retry after close.
+                               conn.Close() // nolint: errcheck
                        },
                        retry:     true,
                        errorText: "no answer",