X-Git-Url: https://git.giacomolli.uk/onechat/blobdiff_plain/ec230eee6b06580031637bc97c99ec6db7b41926..36229ef68a30c5a117599037d79fa1fc708fbfef:/whatsapp_test.go diff --git a/whatsapp_test.go b/whatsapp_test.go index 2504bd9..96ec2df 100644 --- a/whatsapp_test.go +++ b/whatsapp_test.go @@ -2,79 +2,322 @@ package main import ( "context" - "io" - "log" + "errors" "os" "path/filepath" + "strings" "testing" + "testing/synctest" "time" "github.com/stretchr/testify/require" + "go.mau.fi/whatsmeow" + "go.mau.fi/whatsmeow/types" "go.mau.fi/whatsmeow/types/events" ) func TestWhatsAppStatusFollowsTheConnection(t *testing.T) { dir := t.TempDir() whatsappTestSession(t, dir, true) - clock := newTestClock() - fake := &WhatsAppFake{ - connected: make(chan struct{}), - } - - whatsapp, err := openWhatsApp(t.Context(), dir, clock.Now, log.New(io.Discard, "", 0), fake.newClient) - require.NoError(t, err) - - t.Cleanup(func() { - require.NoError(t, whatsapp.Close()) - }) - - ctx, cancel := context.WithCancel(t.Context()) - done := make(chan struct{}) - go func() { - defer close(done) - - whatsapp.Run(ctx) - }() - t.Cleanup(func() { - cancel() - <-done - }) + clock := newTestClock() + whatsapp, fake, _ := whatsappStartTest(t, dir, clock) + daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) - <-fake.connected + <-fake.connects require.Equal(t, "WhatsApp is linked and not connected yet.", whatsapp.Status()) require.True(t, fake.Emit(&events.Connected{})) require.Equal(t, "WhatsApp is linked and connected since 2026-01-01 12:00.", whatsapp.Status()) clock.now = clock.now.Add(20 * time.Minute) + require.True(t, fake.Emit(&events.Disconnected{})) + clock.now = clock.now.Add(time.Minute) + require.True(t, fake.Emit(&events.Disconnected{})) require.Equal(t, "WhatsApp is linked and disconnected since 2026-01-01 12:20. The last connection started at 2026-01-01 12:00.", whatsapp.Status()) } func TestWhatsAppStatusOfAFirstConnectionThatFailed(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + test := whatsappRetryTest(t) + test.fake.connectErr = errors.New("network unavailable") + test.start(t) + synctest.Wait() + + require.Equal(t, "WhatsApp is linked and disconnected since "+time.Now().Format(whatsappTimeLayout)+".", test.whatsapp.Status()) + require.Equal(t, "<4>first connect failed, retrying: network unavailable\n", test.logs.String()) + }) +} + +func TestWhatsAppRetriesTheFirstConnectionWithCappedBackoff(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + test := whatsappRetryTest(t) + for range 10 { + test.fake.connectErrors = append(test.fake.connectErrors, errors.New("network unavailable")) + } + + test.start(t) + synctest.Wait() + require.Len(t, test.fake.Connections(), 1) + require.True(t, test.fake.Emit(&events.Disconnected{})) + require.True(t, test.fake.Emit(&events.Disconnected{})) + + delays := []time.Duration{2 * time.Second, 4 * time.Second, 8 * time.Second, 16 * time.Second, 32 * time.Second, 64 * time.Second, 128 * time.Second, 256 * time.Second, 5 * time.Minute, 5 * time.Minute} + + var outage time.Duration + + for index, delay := range delays { + time.Sleep(delay - time.Nanosecond) + synctest.Wait() + require.Len(t, test.fake.Connections(), index+1) + time.Sleep(time.Nanosecond) + synctest.Wait() + require.Len(t, test.fake.Connections(), index+2) + + outage += delay + } + + times := test.fake.ConnectionTimes() + for index, delay := range delays { + require.Equal(t, delay, times[index+1].Sub(times[index])) + } + + require.True(t, test.fake.Emit(&events.Connected{})) + require.True(t, test.fake.Emit(&events.OfflineSyncCompleted{})) + synctest.Wait() + time.Sleep(10 * time.Minute) + synctest.Wait() + require.Len(t, test.fake.Connections(), 11) + require.Equal(t, "<4>first connect failed, retrying: network unavailable\n<6>connected again after="+durationText(outage)+"\n", test.logs.String()) + }) +} + +func TestWhatsAppFirstConnectionRetriesStopWhenContextEnds(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + test := whatsappRetryTest(t) + test.fake.connectErr = errors.New("network unavailable") + test.start(t) + synctest.Wait() + time.Sleep(2 * time.Second) + synctest.Wait() + require.Len(t, test.fake.Connections(), 2) + + test.cancel() + require.NoError(t, <-test.done) + time.Sleep(10 * time.Minute) + synctest.Wait() + require.Len(t, test.fake.Connections(), 2) + }) +} + +func TestWhatsAppLinkedPairRequestKeepsFirstConnectionRetries(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + test := whatsappRetryTest(t) + test.fake.connectErr = errors.New("network unavailable") + test.start(t) + synctest.Wait() + + answers := make(chan string, 1) + test.whatsapp.Command("pair 15550001111", func(text string) { + answers <- text + }) + require.Equal(t, "WhatsApp is linked already. Run /whatsapp unlink first.", <-answers) + synctest.Wait() + test.fake.mutex.Lock() + + test.fake.connectErr = nil + test.fake.mutex.Unlock() + time.Sleep(whatsappRetryDelay) + synctest.Wait() + require.Len(t, test.fake.Connections(), 2) + require.True(t, test.fake.Emit(&events.Connected{})) + require.True(t, test.fake.Emit(&events.OfflineSyncCompleted{})) + require.Contains(t, test.whatsapp.Status(), "linked and connected since") + time.Sleep(whatsappRetryLimit) + synctest.Wait() + require.Len(t, test.fake.Connections(), 2) + require.Equal(t, "<4>first connect failed, retrying: network unavailable\n<6>connected again after=2s\n", test.logs.String()) + }) +} + +func TestWhatsAppFirstConnectionRetriesStopForLinkChanges(t *testing.T) { + testCases := []struct { + name string + stop func(test *WhatsAppRetryTest) + }{ + { + name: "unlink", + stop: func(test *WhatsAppRetryTest) { + test.whatsapp.Command("unlink", func(_ string) { + }) + }, + }, + { + name: "logout", + stop: func(test *WhatsAppRetryTest) { + test.fake.Emit(&events.LoggedOut{}) + }, + }, + { + name: "permanent disconnect", + stop: func(test *WhatsAppRetryTest) { + test.fake.Emit(&events.StreamReplaced{}) + }, + }, + } + + for _, tc := range testCases { + t.Run(tc.name, func(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + test := whatsappRetryTest(t) + test.fake.connectErr = errors.New("network unavailable") + test.start(t) + synctest.Wait() + tc.stop(test) + synctest.Wait() + time.Sleep(10 * time.Minute) + synctest.Wait() + require.Len(t, test.fake.Connections(), 1) + }) + }) + } +} + +func TestWhatsAppPairsAfterFirstConnectionRetriesStop(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + test := whatsappRetryTest(t) + test.fake.connectErr = errors.New("network unavailable") + test.start(t) + synctest.Wait() + test.whatsapp.Command("unlink", func(_ string) { + }) + synctest.Wait() + require.False(t, test.whatsapp.isLinked()) + + test.fake.mutex.Lock() + + test.fake.connectErr = nil + test.fake.mutex.Unlock() + test.whatsapp.Command("pair 15550001111", func(_ string) { + }) + + items := <-test.fake.pairings + items <- whatsmeow.QRChannelItem{Event: whatsmeow.QRChannelEventCode} + + synctest.Wait() + require.True(t, test.fake.Emit(&events.PairSuccess{ + ID: types.NewADJID(whatsappTestNumber, 0, 1), + LID: types.NewADJID(whatsappTestLID, 0, 1), + })) + + items <- whatsmeow.QRChannelSuccess + + synctest.Wait() + require.True(t, test.whatsapp.isLinked()) + time.Sleep(10 * time.Minute) + synctest.Wait() + require.Len(t, test.fake.Connections(), 2) + require.Equal(t, []string{whatsappTestNumber}, test.fake.Phones()) + }) +} + +func TestWhatsAppInboxFailureStopsFirstConnectionRetries(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + test := whatsappRetryTest(t) + test.fake.connectErr = errors.New("network unavailable") + test.start(t) + synctest.Wait() + + failure := errors.New("state write failed") + test.whatsapp.inbox.failures <- failure + + require.ErrorIs(t, <-test.done, failure) + time.Sleep(10 * time.Minute) + synctest.Wait() + require.Len(t, test.fake.Connections(), 1) + }) +} + +func TestWhatsAppLongFirstConnectionOutageGivesOneNotice(t *testing.T) { + synctest.Test(t, func(t *testing.T) { + test := whatsappRetryTest(t) + test.fake.connectErr = errors.New("network unavailable") + test.start(t) + synctest.Wait() + + since := time.Now().Format(whatsappTimeLayout) + + time.Sleep(whatsappNoticeDelay) + synctest.Wait() + require.Equal(t, 1, test.events.Count("notice")) + require.Equal(t, "WhatsApp is disconnected since "+since+". OneChat tries again.", test.events.Last("notice")) + + time.Sleep(whatsappNoticeDelay) + synctest.Wait() + require.Equal(t, 1, test.events.Count("notice")) + test.fake.mutex.Lock() + + test.fake.connectErr = nil + test.fake.mutex.Unlock() + time.Sleep(whatsappRetryLimit) + synctest.Wait() + require.True(t, test.fake.Emit(&events.Connected{})) + require.True(t, test.fake.Emit(&events.OfflineSyncCompleted{})) + synctest.Wait() + require.Equal(t, 2, test.events.Count("notice")) + require.Equal(t, "WhatsApp is connected again.", test.events.Last("notice")) + }) +} + +func TestWhatsAppStartingRetriesDoNotDuplicateLibraryRetries(t *testing.T) { dir := t.TempDir() whatsappTestSession(t, dir, true) - whatsapp, fake := whatsappStartTest(t, dir) - ctx, cancel := context.WithCancel(t.Context()) - done := make(chan struct{}) - go func() { - defer close(done) + whatsapp, _, _ := whatsappStartTest(t, dir, newTestClock()) + client, ok := whatsappNewClient(whatsapp.device, whatsapp.handle).(*whatsmeow.Client) + require.True(t, ok) + require.False(t, client.InitialAutoReconnect) + require.True(t, client.EnableAutoReconnect) - whatsapp.Run(ctx) - }() + device := whatsapp.container.NewDevice() + client, ok = whatsappNewClient(device, whatsapp.handle).(*whatsmeow.Client) + require.True(t, ok) + require.True(t, client.InitialAutoReconnect) +} - t.Cleanup(func() { - cancel() - <-done - }) +func TestWhatsAppLogsEachChangeOfTheConnectionOnce(t *testing.T) { + dir := t.TempDir() + whatsappTestSession(t, dir, true) + + clock := newTestClock() + whatsapp, fake, logs := whatsappStartTest(t, dir, clock) + daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) + + <-fake.connects + require.True(t, fake.Emit(&events.Connected{})) + + clock.now = clock.now.Add(time.Minute) + + require.True(t, fake.Emit(&events.Disconnected{})) + + clock.now = clock.now.Add(time.Minute) - <-fake.connected require.True(t, fake.Emit(&events.Disconnected{})) - require.Equal(t, "WhatsApp is linked and disconnected since 2026-01-01 12:00.", whatsapp.Status()) + + clock.now = clock.now.Add(25 * time.Second) + + require.True(t, fake.Emit(&events.Connected{})) + + require.Equal(t, []string{ + "<6>connected", + "<4>disconnected, retrying", + "<6>connected again after=1m25s", + }, strings.Split(strings.TrimSuffix(logs.String(), "\n"), "\n")) + require.NotContains(t, logs.String(), whatsappTestNumber) + require.NotContains(t, logs.String(), whatsappTestLID) } func TestWhatsAppIsNotLinkedWithoutALinkedDevice(t *testing.T) { @@ -84,7 +327,7 @@ func TestWhatsAppIsNotLinkedWithoutALinkedDevice(t *testing.T) { }{ { name: "no session file", - session: func(t *testing.T, dir string) { + session: func(_ *testing.T, _ string) { }, }, { @@ -99,8 +342,9 @@ func TestWhatsAppIsNotLinkedWithoutALinkedDevice(t *testing.T) { t.Run(tc.name, func(t *testing.T) { dir := t.TempDir() tc.session(t, dir) - whatsapp, _ := whatsappStartTest(t, dir) - require.Equal(t, "WhatsApp is not linked.", whatsapp.Status()) + + whatsapp, _, _ := whatsappStartTest(t, dir, newTestClock()) + require.Equal(t, "WhatsApp is not linked. Run /whatsapp pair PHONE to link it.", whatsapp.Status()) }) } } @@ -110,7 +354,7 @@ func TestWhatsAppRefusesASessionThatOthersCanRead(t *testing.T) { whatsappTestSession(t, dir, true) require.NoError(t, os.Chmod(filepath.Join(dir, whatsappDirName, whatsappSessionFileName), 0o644)) - _, err := openWhatsApp(t.Context(), dir, time.Now, log.New(io.Discard, "", 0), whatsappNewClient) + _, err := openWhatsApp(t.Context(), dir, time.Now, whatsappDiscardLog(), whatsappNewClient) require.EqualError(t, err, "whatsapp/session.db holds the WhatsApp session, so its mode must be 0600") } @@ -128,18 +372,342 @@ func TestWhatsAppCommandsAnswerOnlyTheClientThatAsked(t *testing.T) { asking.WaitFor(t, "WhatsApp is not linked.") asking.Type(" /whatsapp unknown ") asking.WaitFor(t, whatsappUsage) + asking.Type("/whatsapp pair 0123") + asking.WaitFor(t, "PHONE must be the number of your WhatsApp account") telegram.Add(TelegramUpdate{ UpdateID: 1, Message: telegramOwnerMessage("/whatsapp status"), }) - telegramWaitForSent(t, telegram, "WhatsApp is not linked.") - require.Equal(t, []string{"WhatsApp is not linked."}, telegram.Sent()) + telegramWaitForSent(t, telegram, "WhatsApp is not linked. Run /whatsapp pair PHONE to link it.") + require.Len(t, telegram.Sent(), 1) require.Equal(t, "[connected to OneChat]\n", other.Output()) require.Zero(t, server.Calls()) } +func TestWhatsAppPairsWithACode(t *testing.T) { + dir := t.TempDir() + whatsapp, fake, logs := whatsappStartTest(t, dir, newTestClock()) + server := newModelFake(t) + socket, memory := daemonStartTestWithWhatsApp(t, server, nil, whatsapp) + asking := terminalStartTestClient(t, socket) + other := terminalStartTestClient(t, socket) + asking.WaitFor(t, "[connected to OneChat]") + other.WaitFor(t, "[connected to OneChat]") + + asking.Type("/whatsapp pair +1 555-000-1111") + + items := <-fake.pairings + items <- whatsmeow.QRChannelItem{ + Event: whatsmeow.QRChannelEventCode, + } + + asking.WaitFor(t, whatsappPairSteps+"\n"+whatsappTestCode+"\n") + require.True(t, fake.Emit(&events.PairSuccess{ + ID: types.NewADJID(whatsappTestNumber, 0, 1), + LID: types.NewADJID(whatsappTestLID, 0, 1), + })) + + items <- whatsmeow.QRChannelSuccess + + asking.WaitFor(t, "WhatsApp is linked to +15550001111.") + + // The library connects again after the link with the context of the + // connection, so the end of the pairing must not end it. + connections := fake.Connections() + require.Len(t, connections, 1) + require.Never(t, func() bool { + return connections[0].Err() != nil + }, 200*time.Millisecond, time.Millisecond) + + require.Equal(t, []string{whatsappTestNumber}, fake.Phones()) + require.Equal(t, "WhatsApp is linked and not connected yet.", whatsapp.Status()) + require.Equal(t, "[connected to OneChat]\n", other.Output()) + require.Zero(t, server.Calls()) + require.Equal(t, []string{"WhatsApp is linked."}, whatsappTestLogTexts(t, memory)) + require.Equal(t, "<6>linked\n", logs.String()) + + info, err := os.Stat(filepath.Join(dir, whatsappDirName)) + require.NoError(t, err) + require.Equal(t, os.FileMode(0o700), info.Mode().Perm()) + + info, err = os.Stat(filepath.Join(dir, whatsappDirName, whatsappSessionFileName)) + require.NoError(t, err) + require.Equal(t, os.FileMode(0o600), info.Mode().Perm()) +} + +func TestWhatsAppPairingCodeIsATelegramMessageAlone(t *testing.T) { + whatsapp, fake, _ := whatsappStartTest(t, t.TempDir(), newTestClock()) + telegram := newTelegramFake(t) + bot, _ := telegramStartTestBot(t, telegram) + daemonStartTestWithWhatsApp(t, newModelFake(t), bot, whatsapp) + + telegram.Add(TelegramUpdate{ + UpdateID: 1, + Message: telegramOwnerMessage("/whatsapp pair 15550001111"), + }) + + items := <-fake.pairings + items <- whatsmeow.QRChannelItem{ + Event: whatsmeow.QRChannelEventCode, + } + + telegramWaitForSent(t, telegram, whatsappPairSteps, whatsappTestCode) +} + +func TestWhatsAppPairingEnds(t *testing.T) { + testCases := []struct { + name string + end func(items chan whatsmeow.QRChannelItem) + answer string + }{ + { + name: "the code expires", + end: func(items chan whatsmeow.QRChannelItem) { + items <- whatsmeow.QRChannelTimeout + }, + answer: whatsappPairExpired, + }, + { + name: "the library closes the pairing", + end: func(items chan whatsmeow.QRChannelItem) { + close(items) + }, + answer: whatsappPairExpired, + }, + { + name: "the pairing fails", + end: func(items chan whatsmeow.QRChannelItem) { + items <- whatsmeow.QRChannelItem{ + Event: whatsmeow.QRChannelEventError, + Error: errors.New("bad handshake"), + } + }, + answer: "The pairing failed: bad handshake. Run /whatsapp pair PHONE again.", + }, + } + + for _, tc := range testCases { + t.Run(tc.name, func(t *testing.T) { + whatsapp, fake, _ := whatsappStartTest(t, t.TempDir(), newTestClock()) + socket, _ := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) + client := terminalStartTestClient(t, socket) + client.Type("/whatsapp pair 15550001111") + + items := <-fake.pairings + items <- whatsmeow.QRChannelItem{ + Event: whatsmeow.QRChannelEventCode, + } + + client.WaitFor(t, whatsappTestCode) + tc.end(items) + client.WaitFor(t, tc.answer) + require.Equal(t, "WhatsApp is not linked. Run /whatsapp pair PHONE to link it.", whatsapp.Status()) + }) + } +} + +func TestWhatsAppNewPairingEndsTheOneBefore(t *testing.T) { + whatsapp, fake, _ := whatsappStartTest(t, t.TempDir(), newTestClock()) + socket, _ := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) + client := terminalStartTestClient(t, socket) + + client.Type("/whatsapp pair 15550001111") + <-fake.pairings + client.Type("/whatsapp pair 15550002222") + + items := <-fake.pairings + items <- whatsmeow.QRChannelItem{ + Event: whatsmeow.QRChannelEventCode, + } + + client.WaitFor(t, whatsappTestCode) + require.Equal(t, []string{"15550002222"}, fake.Phones()) + require.NotContains(t, client.Output(), "did not start the pairing") +} + +func TestWhatsAppPairWhenLinked(t *testing.T) { + dir := t.TempDir() + whatsappTestSession(t, dir, true) + + whatsapp, _, _ := whatsappStartTest(t, dir, newTestClock()) + socket, _ := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) + client := terminalStartTestClient(t, socket) + + client.Type("/whatsapp pair 15550001111") + client.WaitFor(t, "WhatsApp is linked already. Run /whatsapp unlink first.") +} + +func TestWhatsAppUnlink(t *testing.T) { + testCases := []struct { + name string + logoutErr error + answer string + }{ + { + name: "with a logout", + answer: "WhatsApp is unlinked.", + }, + { + name: "with no logout", + logoutErr: errors.New("not connected"), + answer: "WhatsApp is unlinked here, but the phone did not get the logout. In WhatsApp on your phone, open Linked devices and remove the device.", + }, + } + + for _, tc := range testCases { + t.Run(tc.name, func(t *testing.T) { + dir := t.TempDir() + whatsappTestSession(t, dir, true) + + whatsapp, fake, logs := whatsappStartTest(t, dir, newTestClock()) + fake.logoutErr = tc.logoutErr + socket, memory := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) + client := terminalStartTestClient(t, socket) + + <-fake.connects + + client.Type("/whatsapp unlink") + client.WaitFor(t, tc.answer) + require.Equal(t, 1, fake.Logouts()) + require.Equal(t, "<6>unlinked\n", logs.String()) + require.NoFileExists(t, filepath.Join(dir, whatsappDirName, whatsappSessionFileName)) + require.Equal(t, "WhatsApp is not linked. Run /whatsapp pair PHONE to link it.", whatsapp.Status()) + require.Equal(t, []string{"WhatsApp is unlinked."}, whatsappTestLogTexts(t, memory)) + + client.Type("/whatsapp unlink") + client.WaitFor(t, "WhatsApp is not linked.\n") + }) + } +} + +func TestWhatsAppLogoutFromThePhone(t *testing.T) { + dir := t.TempDir() + whatsappTestSession(t, dir, true) + + whatsapp, fake, logs := whatsappStartTest(t, dir, newTestClock()) + telegram := newTelegramFake(t) + bot, _ := telegramStartTestBot(t, telegram) + socket, memory := daemonStartTestWithWhatsApp(t, newModelFake(t), bot, whatsapp) + client := terminalStartTestClient(t, socket) + client.WaitFor(t, "[connected to OneChat]") + <-fake.connects + + require.True(t, fake.Emit(&events.LoggedOut{})) + + notice := "WhatsApp was unlinked from the phone. Run /whatsapp pair PHONE to link it again." + client.WaitFor(t, notice) + telegramWaitForSent(t, telegram, notice) + require.Equal(t, "<3>logged out by the phone, run /whatsapp pair PHONE\n", logs.String()) + require.NoFileExists(t, filepath.Join(dir, whatsappDirName, whatsappSessionFileName)) + require.Equal(t, "WhatsApp is not linked. Run /whatsapp pair PHONE to link it.", whatsapp.Status()) + require.Equal(t, []string{"WhatsApp was unlinked from the phone."}, whatsappTestLogTexts(t, memory)) +} + +func TestWhatsAppLongDisconnectionGivesOneNotice(t *testing.T) { + dir := t.TempDir() + whatsappTestSession(t, dir, true) + + clock := newTestClock() + whatsapp, fake, _ := whatsappStartTest(t, dir, clock) + whatsapp.noticeDelay = 300 * time.Millisecond + socket, _ := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) + client := terminalStartTestClient(t, socket) + client.WaitFor(t, "[connected to OneChat]") + <-fake.connects + + require.True(t, fake.Emit(&events.Connected{})) + require.True(t, fake.Emit(&events.Disconnected{})) + require.True(t, fake.Emit(&events.Connected{})) + time.Sleep(400 * time.Millisecond) + require.Equal(t, "[connected to OneChat]\n", client.Output()) + + clock.now = clock.now.Add(time.Hour) + + require.True(t, fake.Emit(&events.Disconnected{})) + require.True(t, fake.Emit(&events.Disconnected{})) + client.WaitFor(t, "WhatsApp is disconnected since 2026-01-01 13:00. OneChat tries again.\n") + require.True(t, fake.Emit(&events.Disconnected{})) + time.Sleep(400 * time.Millisecond) + + require.True(t, fake.Emit(&events.Connected{})) + client.WaitFor(t, "WhatsApp is connected again.\n") + require.Equal(t, 1, strings.Count(client.Output(), "WhatsApp is disconnected since")) +} + +func TestWhatsAppDisconnectionWithNoRetryGivesANoticeAtOnce(t *testing.T) { + dir := t.TempDir() + whatsappTestSession(t, dir, true) + + whatsapp, fake, logs := whatsappStartTest(t, dir, newTestClock()) + socket, _ := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) + client := terminalStartTestClient(t, socket) + client.WaitFor(t, "[connected to OneChat]") + <-fake.connects + + require.True(t, fake.Emit(&events.StreamReplaced{})) + client.WaitFor(t, "WhatsApp is disconnected and does not connect again by itself: stream replaced. Restart the daemon to try again.") + require.Equal(t, "<3>disconnected for good, restart to retry: stream replaced\n", logs.String()) +} + +func TestWhatsAppLogsNoOwnNumber(t *testing.T) { + dir := t.TempDir() + whatsappTestSession(t, dir, true) + + whatsapp, fake, logs := whatsappStartTest(t, dir, newTestClock()) + fake.connectErr = errors.New("no route for " + whatsappTestNumber + "@s.whatsapp.net and " + whatsappTestLID + "@lid") + + daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp) + <-fake.connects + + require.Eventually(t, func() bool { + return logs.String() != "" + }, 10*time.Second, time.Millisecond) + require.Equal(t, "<4>first connect failed, retrying: no route for OWN@s.whatsapp.net and OWN@lid\n", logs.String()) +} + +func TestWhatsAppPhone(t *testing.T) { + testCases := []struct { + name string + phone string + valid bool + }{ + { + name: "a number with a plus and dashes", + phone: "+1-555-000-1111", + valid: true, + }, + { + name: "a number with no country code", + phone: "0115550001111", + valid: false, + }, + { + name: "a short number", + phone: "123456", + valid: false, + }, + { + name: "a long number", + phone: "1234567890123456", + valid: false, + }, + { + name: "a number with letters", + phone: "1555ABC1111", + valid: false, + }, + } + + for _, tc := range testCases { + t.Run(tc.name, func(t *testing.T) { + _, valid := whatsappPhone(tc.phone) + require.Equal(t, tc.valid, valid) + }) + } +} + func TestWhatsAppCommandArgs(t *testing.T) { testCases := []struct { name string @@ -181,3 +749,68 @@ func TestWhatsAppCommandArgs(t *testing.T) { }) } } + +func TestSubagentHasNoWhatsAppTools(t *testing.T) { + box := &Toolbox{} + require.Equal(t, `error: unknown tool "whatsapp_find"`, box.run(t.Context(), "whatsapp_find", `{"name":"ana"}`)) + require.Equal(t, `error: unknown tool "whatsapp_send"`, box.run(t.Context(), "whatsapp_send", `{"id":"a","chat":"15550002222@s.whatsapp.net","text":"hi"}`)) +} + +// WhatsAppRetryTest runs WhatsApp without a model or network client call. All +// timers and channels belong to its synctest bubble, so backoff uses fake time. +type WhatsAppRetryTest struct { + whatsapp *WhatsApp + fake *WhatsAppFake + logs *SyncBuffer + loop *TurnLoop + events *TurnEventRecorder + cancel context.CancelFunc + done chan error +} + +func (r *WhatsAppRetryTest) start(t *testing.T) { + t.Helper() + + ctx, cancel := context.WithCancel(t.Context()) + r.cancel = cancel + r.done = make(chan error, 1) + go func() { + r.done <- r.whatsapp.Run(ctx, r.loop, r.events.Add) + }() + + t.Cleanup(func() { + cancel() + synctest.Wait() + }) +} + +func whatsappRetryTest(t *testing.T) *WhatsAppRetryTest { + t.Helper() + + dir := t.TempDir() + whatsappTestSession(t, dir, true) + + whatsapp, fake, logs := whatsappStartTest(t, dir, newTestClock()) + whatsapp.clock = time.Now + agent, err := openAgent(t.TempDir()) + require.NoError(t, err) + + memory, err := openMemory(t.Context(), agent.dir, time.Now, newFakeSummarizer(), discardLog()) + require.NoError(t, err) + t.Cleanup(func() { + require.NoError(t, memory.Close()) + }) + + events := &TurnEventRecorder{} + client := newModelClient("https://example.com", ModelAPIKey(modelTestKey), agent.CacheKey(), filepath.Join(agent.dir, "usage.jsonl")) + loop, err := newTurnLoop(agent, memory, newTestSubagents(t), whatsapp, newTestSchedules(t, time.Now), client, time.Now, discardLog(), events.Add) + require.NoError(t, err) + + return &WhatsAppRetryTest{ + whatsapp: whatsapp, + fake: fake, + logs: logs, + loop: loop, + events: events, + } +}