X-Git-Url: https://git.giacomolli.uk/onechat/blobdiff_plain/80fa33c0fd65e4110f88f0cab9b19ca26c27d1f6..b2fc2d6a737dd5bab25e57ba822dd07258de93e6:/.agents/skills/check/SKILL.md

diff --git a/.agents/skills/check/SKILL.md b/.agents/skills/check/SKILL.md
index 1526edb..e920bc3 100644
--- a/.agents/skills/check/SKILL.md
+++ b/.agents/skills/check/SKILL.md
@@ -11,13 +11,22 @@ Run every command in the Nix development shell. Use
 ## Procedure
 
 1. Format all files with `bin/format`.
-2. Run the checks with `bin/check`.
+2. Run the checks with `bin/check`. Its golangci-lint config keeps the
+   standard linters and adds `errorlint`, `gocritic`, `testifylint`,
+   `revive`, `wrapcheck`, `nlreturn`, and `wsl_v5`. The settings in
+   `.golangci.yml` match the Go rules.
 3. Run `git add` on new files, then run `nix build` and
    `nix flake check`.
 4. Fix every failure and run the steps again. Do not disable a linter or
    add a `nolint` directive to get a pass, unless the user agrees.
-5. Read the final diff and compare it with `AGENTS.md` and the skills of
-   the task. Passing tools do not replace this review.
+5. Review the final diff against the rules. Passing tools do not replace
+   this review.
+   - Read `AGENTS.md` and the `SKILL.md` of each skill of the task again
+     from disk now. Do not work from memory of an earlier read.
+   - Go through the diff one rule at a time, and for each rule look at
+     every changed line that it covers. For Go code, check each section
+     of `go-code`, also for the tests.
+   - Fix each finding, then run steps 1 to 4 again.
 
 Tell the user about each check that cannot run and each failure that
 stays.