X-Git-Url: https://git.giacomolli.uk/onechat/blobdiff_plain/6e7c7f3d47f086b9d59fe40b91fb071e1528684e..a85d214071706753f358f0af23cfd525c28dbfe0:/whatsapp.go

diff --git a/whatsapp.go b/whatsapp.go
index 4268a16..42b95a8 100644
--- a/whatsapp.go
+++ b/whatsapp.go
@@ -330,7 +330,7 @@ func (w *WhatsApp) Run(ctx context.Context, l *TurnLoop, notify func(Event)) err
 				pairing.Go(func() {
 					defer cancelPair()
 
-					w.pair(pairCtx, l, request.phone, request.answer)
+					w.pair(pairCtx, ctx, l, request.phone, request.answer)
 				})
 			}
 		}
@@ -797,7 +797,13 @@ func (w *WhatsApp) removeSession() error {
 // number, an expired code, or a failure. A pairing that a new one ends gives no
 // answer. A link notes "WhatsApp is linked." in the log of l, with no number.
 // The client of a pairing that does not link is disconnected.
-func (w *WhatsApp) pair(ctx context.Context, l *TurnLoop, phone string, answer func(text string)) {
+//
+// ctx limits the pairing, but the connection uses runCtx, the context of Run.
+// The library keeps the context of the connection for its keep-alive, its event
+// handler, and its reconnections, and after the link the server ends the stream
+// and the library connects again. With ctx, the end of the pairing would stop
+// that reconnection, and the linked device would never connect.
+func (w *WhatsApp) pair(ctx, runCtx context.Context, l *TurnLoop, phone string, answer func(text string)) {
 	device, err := w.newDevice(ctx)
 	if err != nil {
 		answer("The pairing failed: " + err.Error())
@@ -814,7 +820,7 @@ func (w *WhatsApp) pair(ctx context.Context, l *TurnLoop, phone string, answer f
 
 	qr, err := client.GetQRChannel(ctx)
 	if err == nil {
-		err = client.ConnectContext(ctx)
+		err = client.ConnectContext(runCtx)
 	}
 
 	if err != nil {