X-Git-Url: https://git.giacomolli.uk/onechat/blobdiff_plain/0da1ef837bbd190cc5787214187d1b29d62b9410..f0604a9ebbee5783d5213d6176191535f4ed335b:/whatsapp_test.go

diff --git a/whatsapp_test.go b/whatsapp_test.go
index 6785bff..437a8de 100644
--- a/whatsapp_test.go
+++ b/whatsapp_test.go
@@ -2,6 +2,7 @@ package main
 
 import (
 	"errors"
+	"fmt"
 	"net/http"
 	"os"
 	"path/filepath"
@@ -317,7 +318,7 @@ func TestWhatsAppLongDisconnectionGivesOneNotice(t *testing.T) {
 	whatsappTestSession(t, dir, true)
 	clock := newTestClock()
 	whatsapp, fake, _ := whatsappStartTest(t, dir, clock)
-	whatsapp.noticeDelay = 50 * time.Millisecond
+	whatsapp.noticeDelay = 300 * time.Millisecond
 	socket, _ := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
 	client := terminalStartTestClient(t, socket)
 	client.WaitFor(t, "[connected to OneChat]")
@@ -326,7 +327,7 @@ func TestWhatsAppLongDisconnectionGivesOneNotice(t *testing.T) {
 	require.True(t, fake.Emit(&events.Connected{}))
 	require.True(t, fake.Emit(&events.Disconnected{}))
 	require.True(t, fake.Emit(&events.Connected{}))
-	time.Sleep(100 * time.Millisecond)
+	time.Sleep(400 * time.Millisecond)
 	require.Equal(t, "[connected to OneChat]\n", client.Output())
 
 	clock.now = clock.now.Add(time.Hour)
@@ -334,7 +335,7 @@ func TestWhatsAppLongDisconnectionGivesOneNotice(t *testing.T) {
 	require.True(t, fake.Emit(&events.Disconnected{}))
 	client.WaitFor(t, "WhatsApp is disconnected since 2026-01-01 13:00. OneChat tries again.\n")
 	require.True(t, fake.Emit(&events.Disconnected{}))
-	time.Sleep(100 * time.Millisecond)
+	time.Sleep(400 * time.Millisecond)
 
 	require.True(t, fake.Emit(&events.Connected{}))
 	client.WaitFor(t, "WhatsApp is connected again.\n")
@@ -485,11 +486,15 @@ func TestWhatsAppPrivateBatchStartsATurnWithAnEmptyReply(t *testing.T) {
 	socket, memory := daemonStartTestWithWhatsApp(t, server, bot, whatsapp)
 	client := terminalStartTestClient(t, socket)
 	client.WaitFor(t, "[connected to OneChat]")
-	whatsappTestConnect(t, fake)
+	<-fake.connects
 
+	// The catch-up holds the batch open until its end, so the two messages
+	// form one batch also on a slow machine.
+	require.True(t, fake.Emit(&events.Connected{}))
 	at := time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC)
 	require.True(t, fake.Emit(whatsappTestMessage(whatsappTestAna, whatsappTestAna, "m1", "Are you at home?", at)))
 	require.True(t, fake.Emit(whatsappTestMessage(whatsappTestAna, whatsappTestOwn, "m2", "Yes", at)))
+	require.True(t, fake.Emit(&events.OfflineSyncCompleted{}))
 
 	text := "[WhatsApp] Ana Souza, private chat 15550002222@s.whatsapp.net, Thursday 2026-01-01\n12:00 Ana Souza: Are you at home?\n12:00 You: Yes\n" + whatsappBatchEmptyReply
 	client.WaitFor(t, text+"\n[working]\n[done]\n")
@@ -758,3 +763,128 @@ func whatsappTestConnect(t *testing.T, fake *WhatsAppFake) {
 	require.True(t, fake.Emit(&events.Connected{}))
 	require.True(t, fake.Emit(&events.OfflineSyncCompleted{}))
 }
+
+func TestWhatsAppFindMatchesNamesWithNoRegardToCaseAndAccents(t *testing.T) {
+	whatsapp, fake := whatsappStartTestLinked(t)
+	fake.groups = []*types.GroupInfo{
+		{
+			JID: whatsappTestFamily,
+			GroupName: types.GroupName{
+				Name: "Família Souza",
+			},
+		},
+	}
+
+	whatsappTestContacts(t, whatsapp)
+	daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+	whatsappTestConnect(t, fake)
+
+	testCases := []struct {
+		name   string
+		query  string
+		answer string
+	}{
+		{
+			name:   "no accent finds an accent",
+			query:  "joao",
+			answer: "15550004444@s.whatsapp.net | João Silva | contact",
+		},
+		{
+			name:   "a part of a name finds contacts and groups",
+			query:  "SOUZA",
+			answer: "15550002222@s.whatsapp.net | Ana Souza | contact\n120363000000000001@g.us | Família Souza | group",
+		},
+		{
+			name:   "a business name",
+			query:  "bakery",
+			answer: "15550005555@s.whatsapp.net | Corner Bakery | contact",
+		},
+		{
+			name:   "no match",
+			query:  "Zed",
+			answer: "No contact or group has a name with \"Zed\".",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			answer, err := whatsapp.Find(t.Context(), tc.query)
+			require.NoError(t, err)
+			require.Equal(t, tc.answer, answer)
+		})
+	}
+}
+
+func TestWhatsAppFindGivesAtMostTwentyMatches(t *testing.T) {
+	whatsapp, _ := whatsappStartTestLinked(t)
+	for index := range 25 {
+		jid := types.NewJID(fmt.Sprintf("1555001%04d", index), types.DefaultUserServer)
+		require.NoError(t, whatsapp.device.Contacts.PutContactName(t.Context(), jid, "", fmt.Sprintf("Member %02d", index)))
+	}
+
+	answer, err := whatsapp.Find(t.Context(), "member")
+	require.NoError(t, err)
+
+	lines := strings.Split(answer, "\n")
+	require.Len(t, lines, 22)
+	require.Equal(t, "15550010000@s.whatsapp.net | Member 00 | contact", lines[0])
+	require.Equal(t, "5 more: give a longer part of the name.", lines[20])
+	require.Equal(t, "The groups are not in this answer, because WhatsApp is disconnected.", lines[21])
+}
+
+func TestWhatsAppFindBeforeTheNamesArrive(t *testing.T) {
+	whatsapp, fake := whatsappStartTestLinked(t)
+	daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+	whatsappTestConnect(t, fake)
+
+	answer, err := whatsapp.Find(t.Context(), "ana")
+	require.NoError(t, err)
+	require.Equal(t, whatsappNamesNotReady, answer)
+}
+
+func TestWhatsAppFindWithoutALink(t *testing.T) {
+	whatsapp, _, _ := whatsappStartTest(t, t.TempDir(), newTestClock())
+
+	answer, err := whatsapp.Find(t.Context(), "ana")
+	require.NoError(t, err)
+	require.Equal(t, whatsappNotLinked, answer)
+}
+
+func TestAgentFindsAWhatsAppContact(t *testing.T) {
+	whatsapp, fake := whatsappStartTestLinked(t)
+	whatsappTestContacts(t, whatsapp)
+	server := newModelFake(t)
+	server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
+		if call.number == 0 {
+			modelWriteEvents(w, modelCompletedEvent([]any{modelFunctionCallItem("fc_1", "call_1", "whatsapp_find", `{"name":"ana"}`)}, 100, 0, 5))
+			return
+		}
+
+		modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem("Found Ana.")}, 100, 0, 5))
+	}
+
+	socket, _ := daemonStartTestWithWhatsApp(t, server, nil, whatsapp)
+	client := terminalStartTestClient(t, socket)
+	whatsappTestConnect(t, fake)
+
+	client.Type("Find Ana on WhatsApp.")
+	client.WaitFor(t, "[result] 15550002222@s.whatsapp.net | Ana Souza | contact\nFound Ana.\n[done]")
+}
+
+func TestSubagentHasNoWhatsAppTools(t *testing.T) {
+	box := &Toolbox{}
+	require.Equal(t, `error: unknown tool "whatsapp_find"`, box.run(t.Context(), "whatsapp_find", `{"name":"ana"}`))
+}
+
+// whatsappTestContacts puts the contacts of the tests into the session of
+// whatsapp: Ana Souza, Joao Silva with an accent, a business, and the user.
+func whatsappTestContacts(t *testing.T, whatsapp *WhatsApp) {
+	t.Helper()
+
+	contacts := whatsapp.device.Contacts
+	require.NoError(t, contacts.PutContactName(t.Context(), whatsappTestAna, "Ana", "Ana Souza"))
+	require.NoError(t, contacts.PutContactName(t.Context(), types.NewJID("15550004444", types.DefaultUserServer), "João", "João Silva"))
+	_, _, err := contacts.PutBusinessName(t.Context(), types.NewJID("15550005555", types.DefaultUserServer), "Corner Bakery")
+	require.NoError(t, err)
+	require.NoError(t, contacts.PutContactName(t.Context(), whatsappTestOwn, "Me", "Me Souza"))
+}