Name timeouts for the operations they limit

[onechat] / log_test.go

diff --git a/log_test.go b/log_test.go
index 60b9b6428e68d2576fd35b933125e4e50f186ebc..5b3042661359eb903ec61745261a51e532dc5825 100644 (file)
--- a/log_test.go
+++ b/log_test.go
@@ -16,6 +16,7 @@ func TestLogReopenLoadsTheSameMessages(t *testing.T) {
        require.NoError(t, err)
 
        var written []Message
        require.NoError(t, err)
 
        var written []Message

+

        for _, kind := range []string{"user", "reply", "tool", "echo", "work", "note"} {
                message, err := log.Append(kind, kind+" text ✓")
                require.NoError(t, err)
        for _, kind := range []string{"user", "reply", "tool", "echo", "work", "note"} {
                message, err := log.Append(kind, kind+" text ✓")
                require.NoError(t, err)


@@ -35,6 +36,7 @@ func TestLogReopenLoadsTheSameMessages(t *testing.T) {
        }()
 
        require.Equal(t, len(written), log.Len())
        }()
 
        require.Equal(t, len(written), log.Len())

+

        for _, message := range written {
                read, err := log.Message(message.ID)
                require.NoError(t, err)
        for _, message := range written {
                read, err := log.Message(message.ID)
                require.NoError(t, err)


@@ -62,7 +64,7 @@ func TestLogBuildsAMissingIndexAgain(t *testing.T) {
        require.NoError(t, log.Close())
 
        // A missing index, and an index that a crash cut in a record.
        require.NoError(t, log.Close())
 
        // A missing index, and an index that a crash cut in a record.

-       for _, cut := range []func(string) error{os.Remove, truncateToOneAndAHalf} {
+       for _, cut := range []func(string) error{os.Remove, logTruncateToOneAndAHalf} {

                require.NoError(t, cut(filepath.Join(root, "index", "main.idx")))
 
                log, err = openLog(t.Context(), root, clock.Now)
                require.NoError(t, cut(filepath.Join(root, "index", "main.idx")))
 
                log, err = openLog(t.Context(), root, clock.Now)


@@ -95,11 +97,11 @@ func TestLogWritesOneFilePerDay(t *testing.T) {
 
        first, err := os.ReadFile(filepath.Join(root, "main", "2026-01-01.jsonl"))
        require.NoError(t, err)
 
        first, err := os.ReadFile(filepath.Join(root, "main", "2026-01-01.jsonl"))
        require.NoError(t, err)

-       require.Equal(t, `{"i":0,"kind":"user","text":"first day","size":9,"date":"2026-01-01T12:00:00Z"}`+"\n", string(first))
+       require.JSONEq(t, `{"i":0,"kind":"user","text":"first day","size":9,"date":"2026-01-01T12:00:00Z"}`+"\n", string(first))

 
        second, err := os.ReadFile(filepath.Join(root, "main", "2026-01-02.jsonl"))
        require.NoError(t, err)
 
        second, err := os.ReadFile(filepath.Join(root, "main", "2026-01-02.jsonl"))
        require.NoError(t, err)

-       require.Equal(t, `{"i":1,"kind":"user","text":"second day","size":10,"date":"2026-01-02T12:00:00Z"}`+"\n", string(second))
+       require.JSONEq(t, `{"i":1,"kind":"user","text":"second day","size":10,"date":"2026-01-02T12:00:00Z"}`+"\n", string(second))

 }
 
 func TestLogAllowsOneWriter(t *testing.T) {
 }
 
 func TestLogAllowsOneWriter(t *testing.T) {


@@ -141,22 +143,60 @@ func TestLogRejectsAGapInTheIDs(t *testing.T) {
        require.ErrorContains(t, err, "expected message 0, found 1")
 }
 
        require.ErrorContains(t, err, "expected message 0, found 1")
 }
 

-// truncateToOneAndAHalf cuts the index at path in its second record.
-func truncateToOneAndAHalf(path string) error {
-       return os.Truncate(path, positionBytes+positionBytes/2)
-}
+func TestLogCutsAnIncompleteLastLine(t *testing.T) {
+       root := t.TempDir()
+       clock := newTestClock()
+       log, err := openLog(t.Context(), root, clock.Now)
+       require.NoError(t, err)

 
 

-// testClock is a clock that tests set by hand.
-type testClock struct {
-       now time.Time
+       _, err = log.Append("user", "whole")
+       require.NoError(t, err)
+       require.NoError(t, log.Close())
+
+       path := filepath.Join(root, "main", "2026-01-01.jsonl")
+       file, err := os.OpenFile(path, os.O_WRONLY|os.O_APPEND, 0)
+       require.NoError(t, err)
+
+       _, err = file.WriteString(`{"i":1,"kind":"user","te`)
+       require.NoError(t, err)
+       require.NoError(t, file.Close())
+
+       log, err = openLog(t.Context(), root, clock.Now)
+       require.NoError(t, err)
+       require.Equal(t, 1, log.Len())
+
+       message, err := log.Append("user", "after the cut")
+       require.NoError(t, err)
+       require.Equal(t, 1, message.ID)
+       require.NoError(t, log.Close())
+
+       log, err = openLog(t.Context(), root, clock.Now)
+       require.NoError(t, err)
+
+       defer func() {
+               require.NoError(t, log.Close())
+       }()
+
+       message, err = log.Message(1)
+       require.NoError(t, err)
+       require.Equal(t, "after the cut", message.Text)

 }
 
 }
 

-func newTestClock() *testClock {
-       return &testClock{
-               now: time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC),
-       }
+func TestLogRejectsAnIncompleteLineBeforeTheLastDay(t *testing.T) {
+       root := t.TempDir()
+       require.NoError(t, os.MkdirAll(filepath.Join(root, "main"), 0o700))
+
+       first := `{"i":0,"kind":"user","text":"x","size":1,"date":"2026-01-01T12:00:00Z"}` + "\n" + `{"i":1,"kin`
+       second := `{"i":1,"kind":"user","text":"y","size":1,"date":"2026-01-02T12:00:00Z"}` + "\n"
+
+       require.NoError(t, os.WriteFile(filepath.Join(root, "main", "2026-01-01.jsonl"), []byte(first), 0o600))
+       require.NoError(t, os.WriteFile(filepath.Join(root, "main", "2026-01-02.jsonl"), []byte(second), 0o600))
+
+       _, err := openLog(t.Context(), root, newTestClock().Now)
+       require.ErrorContains(t, err, "ends in an incomplete line")

 }
 
 }
 

-func (c *testClock) Now() time.Time {
-       return c.now
+// logTruncateToOneAndAHalf cuts the index at path in its second record.
+func logTruncateToOneAndAHalf(path string) error {
+       return os.Truncate(path, positionBytes+positionBytes/2)

 }
 }