Add local context to chat operation failures

[onechat] / daemon.go

diff --git a/daemon.go b/daemon.go
index b6595c7624a12ef316f0c01a892584791a5b4637..962070a11e7f38b84709173e96b3c17395b13a6c 100644 (file)
--- a/daemon.go
+++ b/daemon.go
@@ -174,7 +174,9 @@ func (h *DaemonHub) remove(client *DaemonClient) {
        client.once.Do(func() {
                close(client.events)
 
-               _ = client.conn.Close()
+               // The client is removed already, so a close failure cannot
+               // restore it.
+               client.conn.Close() // nolint: errcheck
        })
 }
 
@@ -211,8 +213,11 @@ func daemonRunRequest(l *TurnLoop, whatsapp *WhatsApp, request SocketRequest, an
                }
 
                _, err := l.Submit(terminalSource, request.Text)
+               if err != nil {
+                       return fmt.Errorf("submit terminal message: %w", err)
+               }
 
-               return err
+               return nil
        case "image":
                if !filepath.IsAbs(request.Path) {
                        return errors.New("use /image PATH [caption]")
@@ -250,7 +255,11 @@ func daemonRunRequest(l *TurnLoop, whatsapp *WhatsApp, request SocketRequest, an
                        err = fmt.Errorf("no subagent %s runs", request.Text)
                }
 
-               return err
+               if err != nil {
+                       return fmt.Errorf("stop subagent: %w", err)
+               }
+
+               return nil
        default:
                return fmt.Errorf("unknown request %q", request.Type)
        }
@@ -266,7 +275,7 @@ func daemonRunRequest(l *TurnLoop, whatsapp *WhatsApp, request SocketRequest, an
 func daemon(ctx context.Context, out io.Writer) (err error) {
        dir, err := dataDir()
        if err != nil {
-               return err
+               return fmt.Errorf("find data directory: %w", err)
        }
 
        // Check the socket path before the daemon writes a file, so that a data
@@ -274,22 +283,22 @@ func daemon(ctx context.Context, out io.Writer) (err error) {
        socket := filepath.Join(dir, socketFileName)
        err = checkSocketPath(socket)
        if err != nil {
-               return err
+               return fmt.Errorf("check daemon socket path: %w", err)
        }
 
        config, err := loadConfig(dir)
        if err != nil {
-               return err
+               return fmt.Errorf("load daemon config: %w", err)
        }
 
        botSettings, hasBot, err := loadTelegramConfig(dir)
        if err != nil {
-               return err
+               return fmt.Errorf("load Telegram config: %w", err)
        }
 
        tokens, err := lockTokens(dir)
        if err != nil {
-               return err
+               return fmt.Errorf("lock login tokens: %w", err)
        }
 
        defer func() {
@@ -301,7 +310,7 @@ func daemon(ctx context.Context, out io.Writer) (err error) {
        logger := daemonLogger(out, "onechat: ")
        whatsapp, err := openWhatsApp(ctx, dir, time.Now, daemonLogger(out, "whatsapp: "), whatsappNewClient)
        if err != nil {
-               return err
+               return fmt.Errorf("open WhatsApp: %w", err)
        }
 
        defer func() {
@@ -310,12 +319,12 @@ func daemon(ctx context.Context, out io.Writer) (err error) {
 
        address, auth, err := modelEndpoint(config, dir)
        if err != nil {
-               return err
+               return fmt.Errorf("configure model endpoint: %w", err)
        }
 
        agents, err := openDaemonAgents(ctx, dir, address, auth, config.Compactor, time.Now, logger)
        if err != nil {
-               return err
+               return fmt.Errorf("open daemon agents: %w", err)
        }
 
        defer func() {
@@ -330,7 +339,7 @@ func daemon(ctx context.Context, out io.Writer) (err error) {
 
        listener, err := daemonListenSocket(socket)
        if err != nil {
-               return err
+               return fmt.Errorf("listen for daemon clients: %w", err)
        }
 
        linked := "not linked"
@@ -361,7 +370,7 @@ func daemon(ctx context.Context, out io.Writer) (err error) {
 func daemonListenSocket(path string) (net.Listener, error) {
        err := checkSocketPath(path)
        if err != nil {
-               return nil, err
+               return nil, fmt.Errorf("check daemon socket path: %w", err)
        }
 
        err = os.Remove(path)