Bind external events to permanent agent IDs

[onechat] / daemon_children_test.go

diff --git a/daemon_children_test.go b/daemon_children_test.go
index b377b4d348dff0a6ae946de93954eef9eae901bf..8fcae369de4c8b30fefd50743e1c6b9b3f3b684e 100644 (file)
--- a/daemon_children_test.go
+++ b/daemon_children_test.go
@@ -99,6 +99,37 @@ func TestDaemonToolsCreateAndTellAChildDuringATurn(t *testing.T) {
        }, 5*time.Second, time.Millisecond)
 }
 
        }, 5*time.Second, time.Millisecond)
 }
 

+func TestRuntimeChildAcceptsNotificationsByItsPermanentID(t *testing.T) {
+       test := newDaemonChildrenTest(t)
+       test.server.reply = func(w http.ResponseWriter, _ ModelFakeCall) {
+               modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem("")}, 100, 0, 5))
+       }
+
+       _, err := test.runtime.Create("Garden", "Keep garden plans.")
+       require.NoError(t, err)
+
+       child := test.runtime.messages.Child(test.root.agent.config.Name, "Garden")
+       require.NotNil(t, child)
+
+       receipt, err := test.runtime.messages.Notify(&NotifyInput{
+               AgentID: child.agent.config.ID,
+               Source:  "check",
+               ID:      "runtime-child",
+               Text:    "A new result.",
+       })
+       require.NoError(t, err)
+       require.Equal(t, "accepted", receipt.Status)
+       require.Eventually(t, func() bool {
+               return child.memory.Len() == 1
+       }, 10*time.Second, time.Millisecond)
+       require.Zero(t, test.root.memory.Len())
+
+       logged, err := child.memory.Message(0)
+       require.NoError(t, err)
+       require.Equal(t, "work", logged.Kind)
+       require.Contains(t, logged.Text, "Untrusted external data")
+}
+

 func TestChildCreationRefusesUsedNames(t *testing.T) {
        test := newDaemonChildrenTest(t)
        box := test.root.tools
 func TestChildCreationRefusesUsedNames(t *testing.T) {
        test := newDaemonChildrenTest(t)
        box := test.root.tools


@@ -127,23 +158,23 @@ func TestChildCreationAcceptsAreaNames(t *testing.T) {
                child string
        }{
                {
                child string
        }{
                {

-                       name:  "house area",
+                       name:  "accepts house area",

                        child: "House",
                },
                {
                        child: "House",
                },
                {

-                       name:  "calendar area",
+                       name:  "accepts calendar area",

                        child: "Calendar",
                },
                {
                        child: "Calendar",
                },
                {

-                       name:  "two letters",
+                       name:  "accepts two letters",

                        child: "Ab",
                },
                {
                        child: "Ab",
                },
                {

-                       name:  "capital letters after the first",
+                       name:  "accepts capital letters after the first",

                        child: "ABcD",
                },
                {
                        child: "ABcD",
                },
                {

-                       name:  "thirty-two letters",
+                       name:  "accepts thirty-two letters",

                        child: "A" + strings.Repeat("b", 31),
                },
        }
                        child: "A" + strings.Repeat("b", 31),
                },
        }


@@ -172,43 +203,43 @@ func TestChildCreationRefusesInvalidAreaNames(t *testing.T) {
                child string
        }{
                {
                child string
        }{
                {

-                       name:  "empty name",
+                       name:  "refuses empty name",

                        child: "",
                },
                {
                        child: "",
                },
                {

-                       name:  "one letter",
+                       name:  "refuses one letter",

                        child: "H",
                },
                {
                        child: "H",
                },
                {

-                       name:  "thirty-three letters",
+                       name:  "refuses thirty-three letters",

                        child: "A" + strings.Repeat("b", 32),
                },
                {
                        child: "A" + strings.Repeat("b", 32),
                },
                {

-                       name:  "lowercase initial",
+                       name:  "refuses lowercase initial",

                        child: "house",
                },
                {
                        child: "house",
                },
                {

-                       name:  "two words",
+                       name:  "refuses two words",

                        child: "My House",
                },
                {
                        child: "My House",
                },
                {

-                       name:  "digit",
+                       name:  "refuses digit",

                        child: "House2",
                },
                {
                        child: "House2",
                },
                {

-                       name:  "path",
+                       name:  "refuses path",

                        child: "../House",
                },
                {
                        child: "../House",
                },
                {

-                       name:  "punctuation",
+                       name:  "refuses punctuation",

                        child: "House-",
                },
                {
                        child: "House-",
                },
                {

-                       name:  "non-ASCII initial",
+                       name:  "refuses non-ASCII initial",

                        child: "\u00c1rea",
                },
                {
                        child: "\u00c1rea",
                },
                {

-                       name:  "non-ASCII remainder",
+                       name:  "refuses non-ASCII remainder",

                        child: "Hous\u00e9",
                },
        }
                        child: "Hous\u00e9",
                },
        }