Share general review and documentation rules

[onechat] / compactor_test.go

diff --git a/compactor_test.go b/compactor_test.go
index eaed4feeeb9373b58a59a6b6fa29a4a4980cc016..dcd9c3379edc5d984707c26c815f106923ef2349 100644 (file)
--- a/compactor_test.go
+++ b/compactor_test.go
@@ -129,16 +129,19 @@ func TestCompactorFailsWithoutALine(t *testing.T) {
                want  string
        }{
                {
-                       name: "failed call",
+                       name: "reports the model call failure",
                        reply: func(w http.ResponseWriter, _ ModelFakeCall) {
                                w.WriteHeader(http.StatusInternalServerError)
 
-                               _, _ = io.WriteString(w, "down")
+                               _, err := io.WriteString(w, "down")
+                               if err != nil {
+                                       panic(err)
+                               }
                        },
                        want: "HTTP 500",
                },
                {
-                       name: "tool call and no text",
+                       name: "refuses a response without summary text",
                        reply: func(w http.ResponseWriter, _ ModelFakeCall) {
                                modelWriteEvents(w, modelCompletedEvent([]any{map[string]any{"type": "function_call", "name": "zoom", "arguments": "{}"}}, 100, 0, 5))
                        },
@@ -208,7 +211,7 @@ func newTestCompactor(t *testing.T, server *ModelFake) *Compactor {
        return newCompactor(client, compactorAdaPrompt, ModelConfig{
                Model:  "gpt-test",
                Effort: "high",
-       })
+       }, promptTools(), &ImageStore{dir: t.TempDir()})
 }
 
 // compactorInputTexts returns the text of each user message of call. Each