Move whatsapp_find to its own file

[onechat] / whatsapp_test.go

diff --git a/whatsapp_test.go b/whatsapp_test.go
index 38a7b8d765576a8294db3e5376f9d8af2026a18a..2bdb4cc349e77f8f1fa901f98c11c3641fc4b611 100644 (file)
--- a/whatsapp_test.go
+++ b/whatsapp_test.go
@@ -1,6 +1,8 @@
 package main
 
 import (
 package main
 
 import (

+       "crypto/sha256"
+       "encoding/hex"

        "errors"
        "net/http"
        "os"
        "errors"
        "net/http"
        "os"


@@ -11,8 +13,6 @@ import (
 
        "github.com/stretchr/testify/require"
        "go.mau.fi/whatsmeow"
 
        "github.com/stretchr/testify/require"
        "go.mau.fi/whatsmeow"

-       "go.mau.fi/whatsmeow/proto/waE2E"
-       "go.mau.fi/whatsmeow/proto/waWeb"

        "go.mau.fi/whatsmeow/types"
        "go.mau.fi/whatsmeow/types/events"
 )
        "go.mau.fi/whatsmeow/types"
        "go.mau.fi/whatsmeow/types/events"
 )


@@ -137,6 +137,14 @@ func TestWhatsAppPairsWithACode(t *testing.T) {
        items <- whatsmeow.QRChannelSuccess
        asking.WaitFor(t, "WhatsApp is linked to +15550001111.")
 
        items <- whatsmeow.QRChannelSuccess
        asking.WaitFor(t, "WhatsApp is linked to +15550001111.")
 

+       // The library connects again after the link with the context of the
+       // connection, so the end of the pairing must not end it.
+       connections := fake.Connections()
+       require.Len(t, connections, 1)
+       require.Never(t, func() bool {
+               return connections[0].Err() != nil
+       }, 200*time.Millisecond, time.Millisecond)
+

        require.Equal(t, []string{whatsappTestNumber}, fake.Phones())
        require.Equal(t, "WhatsApp is linked and not connected yet.", whatsapp.Status())
        require.Equal(t, "[connected to OneChat]\n", other.Output())
        require.Equal(t, []string{whatsappTestNumber}, fake.Phones())
        require.Equal(t, "WhatsApp is linked and not connected yet.", whatsapp.Status())
        require.Equal(t, "[connected to OneChat]\n", other.Output())


@@ -317,7 +325,7 @@ func TestWhatsAppLongDisconnectionGivesOneNotice(t *testing.T) {
        whatsappTestSession(t, dir, true)
        clock := newTestClock()
        whatsapp, fake, _ := whatsappStartTest(t, dir, clock)
        whatsappTestSession(t, dir, true)
        clock := newTestClock()
        whatsapp, fake, _ := whatsappStartTest(t, dir, clock)

-       whatsapp.noticeDelay = 50 * time.Millisecond
+       whatsapp.noticeDelay = 300 * time.Millisecond

        socket, _ := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
        client := terminalStartTestClient(t, socket)
        client.WaitFor(t, "[connected to OneChat]")
        socket, _ := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
        client := terminalStartTestClient(t, socket)
        client.WaitFor(t, "[connected to OneChat]")


@@ -326,7 +334,7 @@ func TestWhatsAppLongDisconnectionGivesOneNotice(t *testing.T) {
        require.True(t, fake.Emit(&events.Connected{}))
        require.True(t, fake.Emit(&events.Disconnected{}))
        require.True(t, fake.Emit(&events.Connected{}))
        require.True(t, fake.Emit(&events.Connected{}))
        require.True(t, fake.Emit(&events.Disconnected{}))
        require.True(t, fake.Emit(&events.Connected{}))

-       time.Sleep(100 * time.Millisecond)
+       time.Sleep(400 * time.Millisecond)

        require.Equal(t, "[connected to OneChat]\n", client.Output())
 
        clock.now = clock.now.Add(time.Hour)
        require.Equal(t, "[connected to OneChat]\n", client.Output())
 
        clock.now = clock.now.Add(time.Hour)


@@ -334,7 +342,7 @@ func TestWhatsAppLongDisconnectionGivesOneNotice(t *testing.T) {
        require.True(t, fake.Emit(&events.Disconnected{}))
        client.WaitFor(t, "WhatsApp is disconnected since 2026-01-01 13:00. OneChat tries again.\n")
        require.True(t, fake.Emit(&events.Disconnected{}))
        require.True(t, fake.Emit(&events.Disconnected{}))
        client.WaitFor(t, "WhatsApp is disconnected since 2026-01-01 13:00. OneChat tries again.\n")
        require.True(t, fake.Emit(&events.Disconnected{}))

-       time.Sleep(100 * time.Millisecond)
+       time.Sleep(400 * time.Millisecond)

 
        require.True(t, fake.Emit(&events.Connected{}))
        client.WaitFor(t, "WhatsApp is connected again.\n")
 
        require.True(t, fake.Emit(&events.Connected{}))
        client.WaitFor(t, "WhatsApp is connected again.\n")


@@ -451,222 +459,199 @@ func TestWhatsAppCommandArgs(t *testing.T) {
        }
 }
 
        }
 }
 

-// whatsappTestLogTexts returns the texts of the messages in the log of memory,
-// after the log holds at least one message.
-func whatsappTestLogTexts(t *testing.T, memory *Memory) []string {
-       t.Helper()
-
-       require.Eventually(t, func() bool {
-               return memory.Len() > 0
-       }, 10*time.Second, time.Millisecond)
-
-       var texts []string
-       for id := range memory.Len() {
-               message, err := memory.Message(id)
-               require.NoError(t, err)
-
-               texts = append(texts, message.Text)
-       }
-
-       return texts
+func TestSubagentHasNoWhatsAppTools(t *testing.T) {
+       box := &Toolbox{}
+       require.Equal(t, `error: unknown tool "whatsapp_find"`, box.run(t.Context(), "whatsapp_find", `{"name":"ana"}`))
+       require.Equal(t, `error: unknown tool "whatsapp_send"`, box.run(t.Context(), "whatsapp_send", `{"id":"a","chat":"15550002222@s.whatsapp.net","text":"hi"}`))

 }
 
 }
 

-func TestWhatsAppPrivateBatchStartsATurnWithAnEmptyReply(t *testing.T) {
+func TestWhatsAppSendSendsOnceForEachID(t *testing.T) {

        whatsapp, fake := whatsappStartTestLinked(t)
        whatsapp, fake := whatsappStartTestLinked(t)

-       require.NoError(t, whatsapp.device.Contacts.PutContactName(t.Context(), whatsappTestAna, "Ana", "Ana Souza"))
-
-       server := newModelFake(t)
-       server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
-               modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem("")}, 100, 0, 5))
-       }
+       whatsappTestContacts(t, whatsapp)
+       daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+       whatsappTestConnect(t, fake)

 
 

-       telegram := newTelegramFake(t)
-       bot, _ := telegramStartTestBot(t, telegram)
-       socket, memory := daemonStartTestWithWhatsApp(t, server, bot, whatsapp)
-       client := terminalStartTestClient(t, socket)
-       client.WaitFor(t, "[connected to OneChat]")
-       <-fake.connects
+       answer, err := whatsapp.Send(t.Context(), "keys", whatsappTestAna.String(), "The keys are under the mat.")
+       require.NoError(t, err)
+       require.Equal(t, "Sent to Ana Souza at 12:05.", answer)

 
 

-       at := time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC)
-       require.True(t, fake.Emit(whatsappTestMessage(whatsappTestAna, whatsappTestAna, "m1", "Are you at home?", at)))
-       require.True(t, fake.Emit(whatsappTestMessage(whatsappTestAna, whatsappTestOwn, "m2", "Yes", at)))
+       answer, err = whatsapp.Send(t.Context(), "keys", whatsappTestAna.String(), "The keys are under the mat.")
+       require.NoError(t, err)
+       require.Equal(t, "Sent to Ana Souza at 12:05. This is the answer of the first call with this id: nothing was sent again.", answer)

 
 

-       text := "[WhatsApp] Ana Souza, private chat 15550002222@s.whatsapp.net, Thursday 2026-01-01\n12:00 Ana Souza: Are you at home?\n12:00 You: Yes\n" + whatsappBatchEmptyReply
-       client.WaitFor(t, text+"\n[working]\n[done]\n")
-       require.Equal(t, 1, server.Calls())
-       require.Contains(t, string(server.Call(0).raw), "Are you at home?")
-       require.Equal(t, []string{text}, whatsappTestLogTexts(t, memory))
-       require.Empty(t, telegram.Sent())
-       require.Eventually(t, func() bool {
-               return len(whatsapp.batches.Closed()) == 0
-       }, 10*time.Second, time.Millisecond)
-}
+       _, err = whatsapp.Send(t.Context(), "keys", whatsappTestAna.String(), "Another text.")
+       require.EqualError(t, err, "the id keys belongs to another message: give a new id for each message")

 
 

-func TestWhatsAppGroupTurns(t *testing.T) {
-       testCases := []struct {
-               name    string
-               message func(event *events.Message)
-               line    string
-               turn    bool
-       }{
+       require.Equal(t, []WhatsAppFakeSend{

                {
                {

-                       name: "plain",
-                       message: func(event *events.Message) {
-                       },
-                       line: "12:00 Bruno Lima: Who brings the cake?",
-               },
-               {
-                       name: "mention",
-                       message: func(event *events.Message) {
-                               event.Message = &waE2E.Message{
-                                       ExtendedTextMessage: &waE2E.ExtendedTextMessage{
-                                               Text: new("@" + whatsappTestLID + " can you bring the cake? Call " + whatsappTestNumber + "."),
-                                               ContextInfo: &waE2E.ContextInfo{
-                                                       MentionedJID: []string{whatsappTestLID + "@lid"},
-                                               },
-                                       },
-                               }
-                       },
-                       line: "12:00 Bruno Lima (mentions you): @you can you bring the cake? Call OWN.",
-                       turn: true,
+                       to:   whatsappTestAna.String(),
+                       text: "The keys are under the mat.",
+                       id:   "MSG1",

                },
                },

+       }, fake.Sent())
+
+       again, err := openWhatsAppState(filepath.Join(whatsapp.dir, whatsappStateFileName), whatsappBatchQuiet, whatsappBatchWindow)
+       require.NoError(t, err)
+
+       record, found := again.Send("keys")
+       require.True(t, found)
+       require.Equal(t, whatsappSent, record.State)
+       require.Equal(t, "MSG1", record.MessageID)
+}
+
+func TestWhatsAppSendToAGroup(t *testing.T) {
+       whatsapp, fake := whatsappStartTestLinked(t)
+       fake.groups = []*types.GroupInfo{

                {
                {

-                       name: "reply",
-                       message: func(event *events.Message) {
-                               event.Message = &waE2E.Message{
-                                       ExtendedTextMessage: &waE2E.ExtendedTextMessage{
-                                               Text: new("Who brings the cake?"),
-                                               ContextInfo: &waE2E.ContextInfo{
-                                                       Participant: new(whatsappTestOwn.String()),
-                                               },
-                                       },
-                               }
+                       JID: whatsappTestFamily,
+                       GroupName: types.GroupName{
+                               Name: "Family",

                        },
                        },

-                       line: "12:00 Bruno Lima (replies to you): Who brings the cake?",
-                       turn: true,

                },
        }
 
                },
        }
 

-       for _, tc := range testCases {
-               t.Run(tc.name, func(t *testing.T) {
-                       whatsapp, fake := whatsappStartTestLinked(t)
-                       fake.groups = []*types.GroupInfo{
-                               {
-                                       JID: whatsappTestFamily,
-                                       GroupName: types.GroupName{
-                                               Name: "Family",
-                                       },
-                               },
-                       }
+       daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+       whatsappTestConnect(t, fake)

 
 

-                       server := newModelFake(t)
-                       socket, memory := daemonStartTestWithWhatsApp(t, server, nil, whatsapp)
-                       client := terminalStartTestClient(t, socket)
-                       client.WaitFor(t, "[connected to OneChat]")
-                       <-fake.connects
+       answer, err := whatsapp.Send(t.Context(), "cake", whatsappTestFamily.String(), "I bring the cake.")
+       require.NoError(t, err)
+       require.Equal(t, "Sent to Family at 12:05.", answer)
+}

 
 

-                       event := whatsappTestMessage(whatsappTestFamily, whatsappTestBruno, "m1", "Who brings the cake?", time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC))
-                       event.Info.PushName = "Bruno Lima"
-                       tc.message(event)
-                       require.True(t, fake.Emit(event))
-
-                       text := "[WhatsApp] Family, group 120363000000000001@g.us, Thursday 2026-01-01\n" + tc.line
-                       if tc.turn {
-                               text += "\n" + whatsappBatchEmptyReply
-                               client.WaitFor(t, "[done]")
-                               require.Equal(t, 1, server.Calls())
-                       } else {
-                               client.WaitFor(t, text)
-                               time.Sleep(100 * time.Millisecond)
-                               require.Zero(t, server.Calls())
-                       }
+func TestWhatsAppSendThatFails(t *testing.T) {
+       whatsapp, fake := whatsappStartTestLinked(t)
+       fake.sendErr = errors.New("server error for " + whatsappTestNumber)
+       daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+       whatsappTestConnect(t, fake)

 
 

-                       require.Equal(t, text, whatsappTestLogTexts(t, memory)[0])
-               })
+       for range 2 {
+               answer, err := whatsapp.Send(t.Context(), "keys", whatsappTestAna.String(), "hi")
+               require.NoError(t, err)
+               require.True(t, strings.HasPrefix(answer, "The send failed: server error for OWN."), answer)

        }
        }

+
+       require.Len(t, fake.Sent(), 1)

 }
 
 }
 

-func TestWhatsAppTakesOnlyText(t *testing.T) {
-       at := time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC)
+func TestWhatsAppSendCutByAStop(t *testing.T) {
+       whatsapp, fake := whatsappStartTestLinked(t)
+       daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+       whatsappTestConnect(t, fake)
+
+       digest := sha256.Sum256([]byte("hi"))
+       require.NoError(t, whatsapp.state.PutSend(WhatsAppSend{
+               ID:     "keys",
+               Chat:   whatsappTestAna.String(),
+               Digest: hex.EncodeToString(digest[:]),
+               State:  whatsappSending,
+       }))
+
+       answer, err := whatsapp.Send(t.Context(), "keys", whatsappTestAna.String(), "hi")
+       require.NoError(t, err)
+       require.Contains(t, answer, "its result is unknown")
+       require.Empty(t, fake.Sent())
+}
+
+func TestWhatsAppSendRefuses(t *testing.T) {

        testCases := []struct {
        testCases := []struct {

-               name   string
-               change func(event *events.Message)
+               name string
+               id   string
+               chat string
+               text string
+               err  string

        }{
                {
        }{
                {

-                       name: "an edit",
-                       change: func(event *events.Message) {
-                               event.IsEdit = true
-                       },
-               },
-               {
-                       name: "old history",
-                       change: func(event *events.Message) {
-                               event.SourceWebMsg = &waWeb.WebMessageInfo{}
-                       },
+                       name: "no id",
+                       id:   " ",
+                       chat: whatsappTestAna.String(),
+                       text: "hi",
+                       err:  "the id must have 1 to 100 bytes",

                },
                {
                },
                {

-                       name: "a view-once message",
-                       change: func(event *events.Message) {
-                               event.IsViewOnce = true
-                       },
+                       name: "no text",
+                       id:   "a",
+                       chat: whatsappTestAna.String(),
+                       text: "",
+                       err:  "the text must have 1 to 65536 bytes",

                },
                {
                },
                {

-                       name: "a disappearing message",
-                       change: func(event *events.Message) {
-                               event.IsEphemeral = true
-                       },
-               },
-               {
-                       name: "the chat of the user with itself",
-                       change: func(event *events.Message) {
-                               event.Info.Chat = whatsappTestOwn
-                       },
+                       name: "a name for a chat",
+                       id:   "a",
+                       chat: "Ana Souza",
+                       text: "hi",
+                       err:  `"Ana Souza" is not the ID of a WhatsApp chat: find the ID with whatsapp_find`,

                },
                {
                        name: "a status broadcast",
                },
                {
                        name: "a status broadcast",

-                       change: func(event *events.Message) {
-                               event.Info.Chat = types.StatusBroadcastJID
-                       },
+                       id:   "a",
+                       chat: types.StatusBroadcastJID.String(),
+                       text: "hi",
+                       err:  `"status@broadcast" is not a private chat or a group`,

                },
                {
                },
                {

-                       name: "a photo with a caption",
-                       change: func(event *events.Message) {
-                               event.Message = &waE2E.Message{
-                                       ImageMessage: &waE2E.ImageMessage{
-                                               Caption: new("look"),
-                                       },
-                               }
-                       },
-               },
-               {
-                       name: "a text of spaces",
-                       change: func(event *events.Message) {
-                               event.Message.Conversation = new("  ")
-                       },
+                       name: "the chat of the user",
+                       id:   "a",
+                       chat: whatsappTestOwn.String(),
+                       text: "hi",
+                       err:  "this is the chat of the user with itself: send to another chat",

                },
        }
 
                },
        }
 

+       whatsapp, fake := whatsappStartTestLinked(t)
+       daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+       whatsappTestConnect(t, fake)
+

        for _, tc := range testCases {
                t.Run(tc.name, func(t *testing.T) {
        for _, tc := range testCases {
                t.Run(tc.name, func(t *testing.T) {

-                       whatsapp, _ := whatsappStartTestLinked(t)
-                       event := whatsappTestMessage(whatsappTestAna, whatsappTestAna, "m1", "hi", at)
-                       tc.change(event)
-                       require.True(t, whatsapp.handle(event))
-                       require.NoError(t, whatsapp.batches.CloseAll())
-                       require.Empty(t, whatsapp.batches.Closed())
+                       _, err := whatsapp.Send(t.Context(), tc.id, tc.chat, tc.text)
+                       require.EqualError(t, err, tc.err)

                })
        }
                })
        }

+
+       require.Empty(t, fake.Sent())

 }
 
 }
 

-// whatsappStartTestLinked opens a WhatsApp with a linked device in a temporary
-// directory, with a quiet time of 50 ms for its batches.
-func whatsappStartTestLinked(t *testing.T) (*WhatsApp, *WhatsAppFake) {
-       t.Helper()
+func TestWhatsAppSendWhileDisconnected(t *testing.T) {
+       whatsapp, fake := whatsappStartTestLinked(t)
+       daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+       whatsappTestConnect(t, fake)
+       require.True(t, fake.Emit(&events.Disconnected{}))

 
 

-       dir := t.TempDir()
-       whatsappTestSession(t, dir, true)
-       whatsapp, fake, _ := whatsappStartTest(t, dir, newTestClock())
-       whatsapp.batches.quiet = 50 * time.Millisecond
+       _, err := whatsapp.Send(t.Context(), "keys", whatsappTestAna.String(), "hi")
+       require.EqualError(t, err, "WhatsApp is disconnected, so nothing was sent: try again later")
+
+       require.True(t, fake.Emit(&events.Connected{}))
+       answer, err := whatsapp.Send(t.Context(), "keys", whatsappTestAna.String(), "hi")
+       require.NoError(t, err)
+       require.Equal(t, "Sent to +15550002222 at 12:05.", answer)
+}
+
+func TestWhatsAppSendWithoutALink(t *testing.T) {
+       whatsapp, _, _ := whatsappStartTest(t, t.TempDir(), newTestClock())
+
+       answer, err := whatsapp.Send(t.Context(), "keys", whatsappTestAna.String(), "hi")
+       require.NoError(t, err)
+       require.Equal(t, whatsappNotLinked, answer)
+}
+
+func TestAgentSendsAWhatsAppMessage(t *testing.T) {
+       whatsapp, fake := whatsappStartTestLinked(t)
+       whatsappTestContacts(t, whatsapp)
+       server := newModelFake(t)
+       server.reply = func(w http.ResponseWriter, call ModelFakeCall) {
+               if call.number == 0 {
+                       modelWriteEvents(w, modelCompletedEvent([]any{modelFunctionCallItem("fc_1", "call_1", "whatsapp_send", `{"id":"keys","chat":"15550002222@s.whatsapp.net","text":"The keys are under the mat."}`)}, 100, 0, 5))
+                       return
+               }
+
+               modelWriteEvents(w, modelCompletedEvent([]any{modelMessageItem("Sent.")}, 100, 0, 5))
+       }
+
+       socket, _ := daemonStartTestWithWhatsApp(t, server, nil, whatsapp)
+       client := terminalStartTestClient(t, socket)
+       whatsappTestConnect(t, fake)

 
 

-       return whatsapp, fake
+       client.Type("Tell Ana that the keys are under the mat.")
+       client.WaitFor(t, "[result] Sent to Ana Souza at 12:05.\nSent.\n[done]")
+       require.Len(t, fake.Sent(), 1)

 }
 }