From 88581c0765be50dcabcc2913c38ae6786c426a3a Mon Sep 17 00:00:00 2001 From: "Anderson A. Giacomolli" Date: Mon, 9 Nov 2026 22:47:01 -0300 Subject: [PATCH] Write the log rules in the Go skill The go-code skill gets the rules for log lines: a short event as the message, names, IDs and durations as attributes, the cause in err, a level for each kind of event, and no secrets or personal data. The rules were only in issue comments, so workers missed them, and every Go task reads this skill. --- .agents/skills/go-code/SKILL.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/.agents/skills/go-code/SKILL.md b/.agents/skills/go-code/SKILL.md index 086360a..f9ba075 100644 --- a/.agents/skills/go-code/SKILL.md +++ b/.agents/skills/go-code/SKILL.md @@ -57,6 +57,22 @@ description: Go style rules. Use before you write or review Go code. - When deferred cleanup can fail, use a named `err` result and join the cleanup error with `errors.Join`. +## Logs + +- Log with the `*slog.Logger` of the part (`daemonLogger`). The handler + formats the line; do not format values into the message. +- Write the message as a short event in plain words, such as "receive + failed" or "subagent done". Do not explain what it means or what the + user must do. +- Put names, IDs, counts, and durations in attributes, with short keys + (`name`, `id`, `after`, `retry`). Put the cause in `err`; the handler + writes it last. +- Use info for normal events, warn for a failure that is retried or + loses nothing, and error for a failure that loses data or stops a + part. +- Never log secrets, tokens, message text, or phone numbers. Redact IDs + as the existing code does. + ## Style - Keep function signatures on one line. Write function bodies on more -- 2.53.0