From: Anderson A. Giacomolli Date: Mon, 9 Nov 2026 19:59:28 +0000 (-0300) Subject: Reread the rules from disk in the diff review X-Git-Url: http://git.giacomolli.uk/onechat/commitdiff_plain/7c84ed87ef71088b880a3765b2653e1ded57bf14?ds=inline Reread the rules from disk in the diff review The review step of the check skill makes the worker read AGENTS.md and the skills of the task again just before the commit, then go through the diff one rule at a time. A worker that read the rules only at the start of a long task followed them less, and the tools do not check most style rules. --- diff --git a/.agents/skills/check/SKILL.md b/.agents/skills/check/SKILL.md index 1526edb..4dff349 100644 --- a/.agents/skills/check/SKILL.md +++ b/.agents/skills/check/SKILL.md @@ -16,8 +16,14 @@ Run every command in the Nix development shell. Use `nix flake check`. 4. Fix every failure and run the steps again. Do not disable a linter or add a `nolint` directive to get a pass, unless the user agrees. -5. Read the final diff and compare it with `AGENTS.md` and the skills of - the task. Passing tools do not replace this review. +5. Review the final diff against the rules. Passing tools do not replace + this review. + - Read `AGENTS.md` and the `SKILL.md` of each skill of the task again + from disk now. Do not work from memory of an earlier read. + - Go through the diff one rule at a time, and for each rule look at + every changed line that it covers. For Go code, check each section + of `go-code`, also for the tests. + - Fix each finding, then run steps 1 to 4 again. Tell the user about each check that cannot run and each failure that stays.