X-Git-Url: http://git.giacomolli.uk/onechat/blobdiff_plain/a606686934b4028c29dca8e9dae6b2e188cee9c5..5a93b6124068c2a8748fc0bfbb2a2d151815bcf0:/prompt_test.go?ds=inline diff --git a/prompt_test.go b/prompt_test.go index 4b0ee95..0aa9adb 100644 --- a/prompt_test.go +++ b/prompt_test.go @@ -128,12 +128,13 @@ func TestProbePromptKeepsTheInstructionsPathStable(t *testing.T) { func TestAgentToolsAreStrictAndStable(t *testing.T) { tools := promptTools() - require.Equal(t, []string{"zoom", "date", "shell", "read", "write", "edit", "spawn", "tell", "whatsapp_find", "whatsapp_send", "schedule_set", "schedule_list", "schedule_remove"}, promptToolNames(tools)) + require.Equal(t, []string{"zoom", "date", "shell", "read", "write", "edit", "spawn", "agent_create", "tell", "whatsapp_find", "whatsapp_send", "schedule_set", "schedule_list", "schedule_remove"}, promptToolNames(tools)) require.Equal(t, []string{"zoom", "date", "shell", "read", "write", "edit"}, promptToolNames(promptSubagentTools())) for _, tool := range tools { schema := tool.Parameters.(map[string]any) properties := schema["properties"].(map[string]any) + require.True(t, tool.Strict, tool.Name) require.Equal(t, false, schema["additionalProperties"], tool.Name) require.ElementsMatch(t, slices.Collect(maps.Keys(properties)), schema["required"], tool.Name) @@ -149,12 +150,17 @@ func TestAgentToolsAreStrictAndStable(t *testing.T) { } } -// promptToolNames returns the names of tools. -func promptToolNames(tools []ModelTool) []string { - names := make([]string, len(tools)) - for n, tool := range tools { - names[n] = tool.Name - } - - return names +func TestRootPromptDefinesChildRoutingAndConsent(t *testing.T) { + text := prompt("Ada", "/AGENT/instructions.md", "Keep replies short.") + require.Contains(t, text, "Use agent_create for permanent children, whose areas are in the state.") + require.Contains(t, text, `Use tell for children and subagents, and zoom("Name") for their memory.`) + require.Contains(t, text, "Pass area messages from mixed chats to the right child with sender, date, and\nwords.") + require.Contains(t, text, "Never send a WhatsApp reply drafted by a child without the user's\nagreement.") + require.Contains(t, text, "You act again when a message or your own schedule wakes you.") + require.True(t, strings.HasSuffix(text, "Keep replies short.")) + + child := promptChild("GreenOtter", "Ada", "Keep garden plans.", "/CHILD/instructions.md", "") + require.NotContains(t, child, promptChildrenText) + require.NotContains(t, child, "Use agent_create") + require.Contains(t, child, "Send nothing to WhatsApp. Draft replies in your report instead") }