Log failed turns and the ends of subagents

[onechat] / turn_test.go

diff --git a/turn_test.go b/turn_test.go
index 1d958565550ba81be1fdfb4790460a3d7ac9d1ca..3cb15b280687b891043f7f255a5346f935647f82 100644 (file)
--- a/turn_test.go
+++ b/turn_test.go
@@ -4,6 +4,7 @@ import (
        "context"
        "encoding/json"
        "errors"
        "context"
        "encoding/json"
        "errors"

+       "log"

        "net/http"
        "path/filepath"
        "strings"
        "net/http"
        "path/filepath"
        "strings"


@@ -203,6 +204,7 @@ func TestInterruptEndsTheTurn(t *testing.T) {
        require.NoError(t, err)
        test.events.WaitFor(t, "idle", 2)
        require.Equal(t, "reply: answer", test.Log(t)[2])
        require.NoError(t, err)
        test.events.WaitFor(t, "idle", 2)
        require.Equal(t, "reply: answer", test.Log(t)[2])

+       require.Empty(t, test.logs.String())

 }
 
 func TestFailedCallEndsTheTurnWithoutARetry(t *testing.T) {
 }
 
 func TestFailedCallEndsTheTurnWithoutARetry(t *testing.T) {


@@ -219,6 +221,10 @@ func TestFailedCallEndsTheTurnWithoutARetry(t *testing.T) {
        time.Sleep(50 * time.Millisecond)
        require.Equal(t, 1, server.Calls())
        require.Contains(t, test.events.Last("error"), "HTTP 503")
        time.Sleep(50 * time.Millisecond)
        require.Equal(t, 1, server.Calls())
        require.Contains(t, test.events.Last("error"), "HTTP 503")

+       require.Equal(t, 1, strings.Count(test.logs.String(), "\n"))
+       require.Contains(t, test.logs.String(), "the turn stops before its end, and the agent waits for the next message: ")
+       require.Contains(t, test.logs.String(), "HTTP 503")
+       require.NotContains(t, test.logs.String(), "hello")

 }
 
 func TestViewMessagesOnlyGrowBetweenTurns(t *testing.T) {
 }
 
 func TestViewMessagesOnlyGrowBetweenTurns(t *testing.T) {


@@ -250,6 +256,7 @@ type TurnTestLoop struct {
        memory    *Memory
        loop      *TurnLoop
        events    *TurnEventRecorder
        memory    *Memory
        loop      *TurnLoop
        events    *TurnEventRecorder

+       logs      *SyncBuffer

        usagePath string
 }
 
        usagePath string
 }
 


@@ -387,12 +394,13 @@ func newTestTurnLoopWith(t *testing.T, server *ModelFake, summarizer Summarizer)
                agent:     agent,
                memory:    memory,
                events:    &TurnEventRecorder{},
                agent:     agent,
                memory:    memory,
                events:    &TurnEventRecorder{},

+               logs:      &SyncBuffer{},

                usagePath: filepath.Join(t.TempDir(), "usage.jsonl"),
        }
 
        client := newModelClient(server.URL, ModelAPIKey(modelTestKey), agent.CacheKey(), test.usagePath)
        whatsapp, _, _ := whatsappStartTest(t, t.TempDir(), clock)
                usagePath: filepath.Join(t.TempDir(), "usage.jsonl"),
        }
 
        client := newModelClient(server.URL, ModelAPIKey(modelTestKey), agent.CacheKey(), test.usagePath)
        whatsapp, _, _ := whatsappStartTest(t, t.TempDir(), clock)

-       test.loop, err = newTurnLoop(agent, memory, newTestSubagents(t), whatsapp, newTestSchedules(t, clock.Now), client, clock.Now, test.events.Add)
+       test.loop, err = newTurnLoop(agent, memory, newTestSubagents(t), whatsapp, newTestSchedules(t, clock.Now), client, clock.Now, log.New(test.logs, "", 0), test.events.Add)

        require.NoError(t, err)
        ctx, cancel := context.WithCancel(t.Context())
        done := make(chan error)
        require.NoError(t, err)
        ctx, cancel := context.WithCancel(t.Context())
        done := make(chan error)