Wait for the WhatsApp catch-up before a turn

[onechat] / whatsapp_test.go

diff --git a/whatsapp_test.go b/whatsapp_test.go
index 38a7b8d765576a8294db3e5376f9d8af2026a18a..6785bff7ea9faaf3589ac86fe25583740cf01816 100644 (file)
--- a/whatsapp_test.go
+++ b/whatsapp_test.go
@@ -485,7 +485,7 @@ func TestWhatsAppPrivateBatchStartsATurnWithAnEmptyReply(t *testing.T) {
        socket, memory := daemonStartTestWithWhatsApp(t, server, bot, whatsapp)
        client := terminalStartTestClient(t, socket)
        client.WaitFor(t, "[connected to OneChat]")
        socket, memory := daemonStartTestWithWhatsApp(t, server, bot, whatsapp)
        client := terminalStartTestClient(t, socket)
        client.WaitFor(t, "[connected to OneChat]")

-       <-fake.connects
+       whatsappTestConnect(t, fake)

 
        at := time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC)
        require.True(t, fake.Emit(whatsappTestMessage(whatsappTestAna, whatsappTestAna, "m1", "Are you at home?", at)))
 
        at := time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC)
        require.True(t, fake.Emit(whatsappTestMessage(whatsappTestAna, whatsappTestAna, "m1", "Are you at home?", at)))


@@ -563,7 +563,7 @@ func TestWhatsAppGroupTurns(t *testing.T) {
                        socket, memory := daemonStartTestWithWhatsApp(t, server, nil, whatsapp)
                        client := terminalStartTestClient(t, socket)
                        client.WaitFor(t, "[connected to OneChat]")
                        socket, memory := daemonStartTestWithWhatsApp(t, server, nil, whatsapp)
                        client := terminalStartTestClient(t, socket)
                        client.WaitFor(t, "[connected to OneChat]")

-                       <-fake.connects
+                       whatsappTestConnect(t, fake)

 
                        event := whatsappTestMessage(whatsappTestFamily, whatsappTestBruno, "m1", "Who brings the cake?", time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC))
                        event.Info.PushName = "Bruno Lima"
 
                        event := whatsappTestMessage(whatsappTestFamily, whatsappTestBruno, "m1", "Who brings the cake?", time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC))
                        event.Info.PushName = "Bruno Lima"


@@ -670,3 +670,91 @@ func whatsappStartTestLinked(t *testing.T) (*WhatsApp, *WhatsAppFake) {
 
        return whatsapp, fake
 }
 
        return whatsapp, fake
 }

+
+func TestWhatsAppCatchupGivesOneTurn(t *testing.T) {
+       whatsapp, fake := whatsappStartTestLinked(t)
+       server := newModelFake(t)
+       socket, memory := daemonStartTestWithWhatsApp(t, server, nil, whatsapp)
+       client := terminalStartTestClient(t, socket)
+       client.WaitFor(t, "[connected to OneChat]")
+       <-fake.connects
+
+       require.True(t, fake.Emit(&events.Connected{}))
+       at := time.Date(2026, 1, 1, 8, 0, 0, 0, time.UTC)
+       for index, event := range []*events.Message{
+               whatsappTestMessage(whatsappTestAna, whatsappTestAna, "m1", "Good morning", at),
+               whatsappTestMessage(whatsappTestBruno, whatsappTestBruno, "m2", "Call me", at.Add(time.Hour)),
+               whatsappTestMessage(whatsappTestAna, whatsappTestAna, "m3", "Are you there?", at.Add(2*time.Hour)),
+       } {
+               event.Info.PushName = []string{"Ana", "Bruno", "Ana"}[index]
+               require.True(t, fake.Emit(event))
+       }
+
+       time.Sleep(100 * time.Millisecond)
+       require.Zero(t, memory.Len())
+
+       require.True(t, fake.Emit(&events.OfflineSyncCompleted{}))
+       client.WaitFor(t, "[done]")
+       require.Equal(t, []string{
+               "[WhatsApp] Ana, private chat 15550002222@s.whatsapp.net, Thursday 2026-01-01\n08:00 Ana: Good morning\n" + whatsappBatchEmptyReply,
+               "[WhatsApp] Bruno, private chat 15550003333@s.whatsapp.net, Thursday 2026-01-01\n09:00 Bruno: Call me\n" + whatsappBatchEmptyReply,
+               "[WhatsApp] Ana, private chat 15550002222@s.whatsapp.net, Thursday 2026-01-01\n10:00 Ana: Are you there?\n" + whatsappBatchEmptyReply,
+       }, whatsappTestLogTexts(t, memory)[:3])
+
+       time.Sleep(100 * time.Millisecond)
+       require.Equal(t, 1, server.Calls())
+       for _, text := range []string{"Good morning", "Call me", "Are you there?"} {
+               require.Contains(t, string(server.Call(0).raw), text)
+       }
+}
+
+func TestWhatsAppCatchupEndsAfterItsLimit(t *testing.T) {
+       whatsapp, fake := whatsappStartTestLinked(t)
+       whatsapp.catchupLimit = 100 * time.Millisecond
+       socket, memory := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+       client := terminalStartTestClient(t, socket)
+       client.WaitFor(t, "[connected to OneChat]")
+       <-fake.connects
+
+       require.True(t, fake.Emit(&events.Connected{}))
+       require.True(t, fake.Emit(whatsappTestMessage(whatsappTestAna, whatsappTestOwn, "m1", "On my way.", time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC))))
+       client.WaitFor(t, "12:00 You: On my way.")
+       require.Len(t, whatsappTestLogTexts(t, memory), 1)
+}
+
+func TestWhatsAppBatchesOfTheStateFileWaitForTheCatchup(t *testing.T) {
+       dir := t.TempDir()
+       whatsappTestSession(t, dir, true)
+       before, _, _ := whatsappStartTest(t, dir, newTestClock())
+       _, err := before.batches.Add(whatsappTestChat, WhatsAppMessage{
+               ID:     "m1",
+               Sender: "Ana Souza",
+               Time:   time.Date(2026, 1, 1, 12, 0, 0, 0, time.UTC),
+               Text:   "Did you see my message?",
+       }, time.Now().Add(-time.Hour))
+       require.NoError(t, err)
+
+       whatsapp, fake, _ := whatsappStartTest(t, dir, newTestClock())
+       socket, memory := daemonStartTestWithWhatsApp(t, newModelFake(t), nil, whatsapp)
+       client := terminalStartTestClient(t, socket)
+       client.WaitFor(t, "[connected to OneChat]")
+       <-fake.connects
+
+       time.Sleep(100 * time.Millisecond)
+       require.Zero(t, memory.Len())
+
+       require.True(t, fake.Emit(&events.Connected{}))
+       require.True(t, fake.Emit(&events.OfflineSyncCompleted{}))
+       client.WaitFor(t, "12:00 Ana Souza: Did you see my message?")
+       client.WaitFor(t, "[done]")
+}
+
+// whatsappTestConnect waits for the connection of the daemon and gives it the
+// events of a connection with an empty catch-up.
+func whatsappTestConnect(t *testing.T, fake *WhatsAppFake) {
+       t.Helper()
+
+       <-fake.connects
+       require.True(t, fake.Emit(&events.Connected{}))
+       require.True(t, fake.Emit(&events.OfflineSyncCompleted{}))
+}